You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/20 09:13:54 UTC
[GitHub] [bookkeeper] Nicklee007 opened a new pull request, #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Nicklee007 opened a new pull request, #3349:
URL: https://github.com/apache/bookkeeper/pull/3349
### Motivation
we need release all quarantined bookies when we use the dynamic config to disable the health check. In some case, we disable the health check when the client has add all bookies to `quarantinedBookies`, then we want to recovery all client's read/write capability immediately.
But now we need wait `BOOKIE_QUARANTINE_TIME_SECONDS` reached or we need restart all client, it's too slowly to recovery the client read/write for us.
### Changes
Release all `QuarantinedBookies`, after we dynamic disable the health check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#issuecomment-1194966186
@Nicklee007 Would you please rebase the master to make the CI pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Nicklee007 commented on pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#issuecomment-1167111502
@eolivelli Please take again look, Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#discussion_r902401883
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcherImpl.java:
##########
@@ -359,5 +359,9 @@ public void quarantineBookie(BookieId bookie) {
}
}
-
+ public void releaseAllQuarantinedBookies(){
+ if (quarantinedBookies.size() > 0){
Review Comment:
why do you need this condition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#issuecomment-1194884932
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Nicklee007 commented on pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#issuecomment-1174851052
run failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Nicklee007 commented on pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#issuecomment-1194988158
> @Nicklee007 Would you please rebase the master to make the CI pass?
@hangc0276 Rebased to master branch,PTAL Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Nicklee007 commented on a diff in pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on code in PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#discussion_r902421305
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcherImpl.java:
##########
@@ -359,5 +359,9 @@ public void quarantineBookie(BookieId bookie) {
}
}
-
+ public void releaseAllQuarantinedBookies(){
+ if (quarantinedBookies.size() > 0){
Review Comment:
This judgment seems superfluous and has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#issuecomment-1194889545
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 merged pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
hangc0276 merged PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#issuecomment-1194427243
run failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Nicklee007 commented on pull request #3349: [improve][client] release the bookie from QuarantinedBookies when health check is disabled
Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on PR #3349:
URL: https://github.com/apache/bookkeeper/pull/3349#issuecomment-1160188851
@lordcheng10 I want change the behaviour after dynamic disable the health check, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org