You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "mercyblitz (GitHub)" <gi...@apache.org> on 2018/10/18 08:54:24 UTC
[GitHub] [incubator-dubbo] mercyblitz opened pull request #2657:
@Service and @Reference Optimization
## What is the purpose of the change
- [Enhancement] Reactor the generation rule for @Service Bean name #2235
- [Feature] Introduce a new Spring ApplicationEvent for ServiceBean exporting #2251
- [Bug Fix] apache/incubator-dubbo-spring-boot-project#243
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2657 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang closed pull request #2657:
@Service and @Reference Optimization
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
[ pull request closed by zonghaishang ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2657 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] cvictory commented on issue #2657:
@Service and @Reference Optimization
Posted by "cvictory (GitHub)" <gi...@apache.org>.
We should commit a pr to master .
Because we should carry farword in master and 2.6.x util 2.7.x release.
Xin Wang <no...@github.com> 于2018年10月18日周四 下午8:53写道：
> Is this issue also need to be merged to master?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-dubbo/pull/2657#issuecomment-430996418>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AD5mbAyzIZr88HKYWMLt9WR8abfWEXUaks5umHm4gaJpZM4Xs94A>
> .
>
--
Best Regard!
cvitory
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2657 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang commented on issue #2657:
@Service and @Reference Optimization
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
It looks good
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2657 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] lovepoem commented on issue #2657:
@Service and @Reference Optimization
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
Is this issue also need to be merged to master?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2657 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2657:
@Service and @Reference Optimization
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2657?src=pr&el=h1) Report
> Merging [#2657](https://codecov.io/gh/apache/incubator-dubbo/pull/2657?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/2e826a65c7f792b2e6f4979777ce295b00d0c2b6?src=pr&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `86.13%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2657?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.6.x #2657 +/- ##
============================================
- Coverage 47.56% 47.37% -0.19%
+ Complexity 4305 4296 -9
============================================
Files 557 557
Lines 24409 24380 -29
Branches 4326 4313 -13
============================================
- Hits 11609 11549 -60
- Misses 11001 11045 +44
+ Partials 1799 1786 -13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2657?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nnotation/AbstractAnnotationConfigBeanBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9BYnN0cmFjdEFubm90YXRpb25Db25maWdCZWFuQnVpbGRlci5qYXZh) | `93.33% <100%> (ø)` | `9 <0> (ø)` | :arrow_down: |
| [...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9TZXJ2aWNlQW5ub3RhdGlvbkJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `83.08% <100%> (-1.74%)` | `31 <1> (-3)` | |
| [...ans/factory/annotation/ServiceBeanNameBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9TZXJ2aWNlQmVhbk5hbWVCdWlsZGVyLmphdmE=) | `100% <100%> (ø)` | `12 <12> (?)` | |
| [...spring/context/event/ServiceBeanExportedEvent.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2NvbnRleHQvZXZlbnQvU2VydmljZUJlYW5FeHBvcnRlZEV2ZW50LmphdmE=) | `100% <100%> (ø)` | `2 <2> (?)` | |
| [...a/com/alibaba/dubbo/config/spring/ServiceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1NlcnZpY2VCZWFuLmphdmE=) | `55.86% <100%> (+2.92%)` | `45 <4> (+4)` | :arrow_up: |
| [...beans/factory/annotation/ReferenceBeanBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9SZWZlcmVuY2VCZWFuQnVpbGRlci5qYXZh) | `71.11% <38.46%> (-16.07%)` | `12 <1> (ø)` | |
| [...baba/dubbo/config/spring/util/AnnotationUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3V0aWwvQW5ub3RhdGlvblV0aWxzLmphdmE=) | `61.11% <44.44%> (-16.67%)` | `9 <4> (+4)` | |
| [...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9SZWZlcmVuY2VBbm5vdGF0aW9uQmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `98.61% <98.36%> (+21.33%)` | `25 <24> (+1)` | :arrow_up: |
| [.../spring/schema/AnnotationBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3NjaGVtYS9Bbm5vdGF0aW9uQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `9.09% <0%> (-81.82%)` | `1% <0%> (-3%)` | |
| [...com/alibaba/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL1JlZmVyZW5jZUJlYW4uamF2YQ==) | `22.22% <0%> (-23.46%)` | `6% <0%> (-14%)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2657/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2657?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2657?src=pr&el=footer). Last update [2e826a6...b3dbe9e](https://codecov.io/gh/apache/incubator-dubbo/pull/2657?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2657 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org