You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org> on 2023/05/23 14:30:49 UTC

[Impala-ASF-CR] IMPALA-12158: Added -f to "pgrep impalad" commands

Gergely Fürnstáhl has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19917 )

Change subject: IMPALA-12158: Added -f to "pgrep impalad" commands
......................................................................

IMPALA-12158: Added -f to "pgrep impalad" commands

IMPALA-10794 introduced names for threads, which messed up process names
too in catalogd and impalad.

By default, pgrep matches the search string only on the process name,
with -f it will look into the program's path too.

My testing showed it only happens in local catalog mode, so not all
pgrep calls were broken (e.g. graceful shutdown test was passing, but
the script does nothing if I start the cluster with local catalog mode).

I think it is safer to add -f everywhere.

Testing:
  - Tested locally with bin/coverage_report.sh and
bin/graceful_shutdown_backends.sh

Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
---
M bin/coverage_helper.sh
M bin/dump-stacktraces.sh
M bin/graceful_shutdown_backends.sh
M tests/common/impala_service.py
M tests/comparison/cluster.py
M tests/query_test/test_tablesample.py
6 files changed, 10 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/19917/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47e462a28d2f7c5ff202bf8614caafb57cc1e25b
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>