You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/05/11 12:10:50 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request, #6376: UI: Add missing tooltips on service offering creation
nvazquez opened a new pull request, #6376:
URL: https://github.com/apache/cloudstack/pull/6376
### Description
This PR adds the missing tooltips helpers to fields in the service offering creation
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1123722427
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a diff in pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on code in PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#discussion_r870246504
##########
ui/src/views/offering/AddComputeOffering.vue:
##########
@@ -340,7 +340,7 @@
</a-form-item>
<a-form-item name="computeonly" ref="computeonly">
<template #label>
- {{ $t('label.computeonly.offering') }}
+ <tooltip-label :title="$t('label.computeonly.offering')" tooltip="Option to specify root disk related information in the compute offering or to link a disk offering to the compute offering"/>
Review Comment:
@nvazquez can you add the tooltip message to en.json file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124711124
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124500041
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124502791
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6376 (SL-JID-1561)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#discussion_r870263349
##########
ui/src/views/offering/AddComputeOffering.vue:
##########
@@ -340,7 +340,7 @@
</a-form-item>
<a-form-item name="computeonly" ref="computeonly">
<template #label>
- {{ $t('label.computeonly.offering') }}
+ <tooltip-label :title="$t('label.computeonly.offering')" tooltip="Option to specify root disk related information in the compute offering or to link a disk offering to the compute offering"/>
Review Comment:
I think, most of the tooltip descriptions are from the API params, and are not translated. In that case, this is in consistent with the other tooltips.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124633763
@blueorangutan build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1123680758
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6376 (SL-JID-1551)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124636093
@andrijapanicsb I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu20', 'rocky8']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-alma8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.
Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'nvazquez', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti', 'weizhouapache', 'NuxRo']
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1123671414
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1123722225
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1123780936
Looks good on the QA server (disk strictness checkbox is missing, since it's 4.16.1 based/ACS)
I would like to have this disk strictness also with tooltip - do we have links when user click on that, that leads to the documentation (as with other tooltips?)
This one here:
I see (if I see correctly...) that the Decoupling of disk from service offering documentation is missing?
http://docs.cloudstack.apache.org/en/latest/adminguide/service_offerings.html#creating-a-new-compute-offering
the main branch also is missing it: https://github.com/apache/cloudstack-documentation/blob/main/source/adminguide/service_offerings.rst
This needs be corrected (asynchronously from this PR) @harikrishna-patnala cc @nvazquez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#discussion_r870245735
##########
ui/src/views/offering/AddComputeOffering.vue:
##########
@@ -340,7 +340,7 @@
</a-form-item>
<a-form-item name="computeonly" ref="computeonly">
<template #label>
- {{ $t('label.computeonly.offering') }}
+ <tooltip-label :title="$t('label.computeonly.offering')" tooltip="Option to specify root disk related information in the compute offering or to link a disk offering to the compute offering"/>
Review Comment:
```suggestion
<tooltip-label :title="$t('label.computeonly.offering')" tooltip="Option to directly map root disk related information to the compute offering"/>
```
cc @harikrishna-patnala please advise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
nvazquez commented on code in PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#discussion_r870304705
##########
ui/src/views/offering/AddComputeOffering.vue:
##########
@@ -340,7 +340,7 @@
</a-form-item>
<a-form-item name="computeonly" ref="computeonly">
<template #label>
- {{ $t('label.computeonly.offering') }}
+ <tooltip-label :title="$t('label.computeonly.offering')" tooltip="Option to specify root disk related information in the compute offering or to link a disk offering to the compute offering"/>
Review Comment:
Sorry @sureshanaparti have missed your comment - it is already fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124500267
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a diff in pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
shwstppr commented on code in PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#discussion_r870972000
##########
ui/public/locales/en.json:
##########
@@ -899,6 +899,7 @@
"label.diskofferingstrictness": "Disk offering strictness",
"label.disksizestrictness": "Disk size strictness",
"label.computeonly.offering": "Compute only disk offering",
+"label.computeonly.offering.tooltip": "Option to specify root disk related information in the compute offering or to directly link a disk offering to the compute offering",
Review Comment:
Just nit-picking, we have not been using translation keys like "*.tooltip" so will it be better to use something like "message.offering.computeonly"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1123673488
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
nvazquez commented on code in PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#discussion_r870263445
##########
ui/src/views/offering/AddComputeOffering.vue:
##########
@@ -340,7 +340,7 @@
</a-form-item>
<a-form-item name="computeonly" ref="computeonly">
<template #label>
- {{ $t('label.computeonly.offering') }}
+ <tooltip-label :title="$t('label.computeonly.offering')" tooltip="Option to specify root disk related information in the compute offering or to link a disk offering to the compute offering"/>
Review Comment:
Copy, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124650113
@andrijapanicsb a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124649255
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1123714454
What about "Disk offering strictness" checkbox?
Any reason to say that it won't work with deploy-as-is templates unless we are using custom disk size, etc, @nvazquez ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#discussion_r870920211
##########
ui/src/views/offering/AddComputeOffering.vue:
##########
@@ -340,7 +340,7 @@
</a-form-item>
<a-form-item name="computeonly" ref="computeonly">
<template #label>
- {{ $t('label.computeonly.offering') }}
+ <tooltip-label :title="$t('label.computeonly.offering')" tooltip="Option to specify root disk related information in the compute offering or to link a disk offering to the compute offering"/>
Review Comment:
@sureshanaparti, I think it is better to mention both cases.
how about "Option to map root disk related information directly with a disk offering". If we say this we might have to change the toggle button from "Compute only offering" to "Map to a disk offering" and keep it off by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124634330
@blueorangutan help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#discussion_r870986683
##########
ui/src/views/offering/AddComputeOffering.vue:
##########
@@ -340,7 +340,7 @@
</a-form-item>
<a-form-item name="computeonly" ref="computeonly">
<template #label>
- {{ $t('label.computeonly.offering') }}
+ <tooltip-label :title="$t('label.computeonly.offering')" tooltip="Option to specify root disk related information in the compute offering or to link a disk offering to the compute offering"/>
Review Comment:
ok @harikrishna-patnala if both cases makes sense for "Compute only offering", keep that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124709469
Come on @blueorangutan , you can do it, it's been a while....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#discussion_r870263349
##########
ui/src/views/offering/AddComputeOffering.vue:
##########
@@ -340,7 +340,7 @@
</a-form-item>
<a-form-item name="computeonly" ref="computeonly">
<template #label>
- {{ $t('label.computeonly.offering') }}
+ <tooltip-label :title="$t('label.computeonly.offering')" tooltip="Option to specify root disk related information in the compute offering or to link a disk offering to the compute offering"/>
Review Comment:
I think, most of the tooltip descriptions are from the API params (not from translation file), and are not translated. In that case, this is in consistent with the other tooltips.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1123810424
@andrijapanicsb the tooltip has been added to the disk strictness. There is a documentation PR for that change which is still in progress cc @harikrishna-patnala https://github.com/apache/cloudstack-documentation/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1123729149
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6376 (SL-JID-1554)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1123725886
@andrijapanicsb that description is coming from the API field description - @harikrishna-patnala any comments on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6376: UI: Add missing tooltips on service offering creation
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6376:
URL: https://github.com/apache/cloudstack/pull/6376#issuecomment-1124524666
>
It did not say anything about deploy as is templates
> Looks good on the QA server (disk strictness checkbox is missing, since it's 4.16.1 based/ACS)
>
> I would like to have this disk strictness also with tooltip - do we have links when user click on that, that leads to the documentation (as with other tooltips?)
>
> This one here:
>
> 
>
> I see (if I see correctly...) that the Decoupling of disk from service offering documentation is missing? http://docs.cloudstack.apache.org/en/latest/adminguide/service_offerings.html#creating-a-new-compute-offering the main branch also is missing it: https://github.com/apache/cloudstack-documentation/blob/main/source/adminguide/service_offerings.rst
>
> This needs be corrected (asynchronously from this PR) @harikrishna-patnala cc @nvazquez
I'm working on the doc PR, will update it asap.
Regarding "disk offering strictness" missing, I see it on other environments along with this PR changes also. So may be some issue with qa server not up to date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org