[GitHub] [cassandra-accord] dcapwell commented on a diff in pull request #18: CASSANDRA-17112: Publish StrictSerializabilityVerifier so Cassandra may use, and fixed bugs found with the integration

[GitBox <gi...@apache.org>]

dcapwell commented on code in PR #18:
URL: https://github.com/apache/cassandra-accord/pull/18#discussion_r1061006125


##########
accord-core/src/test/java/accord/verify/StrictSerializabilityVerifier.java:
##########
@@ -606,7 +623,9 @@ void insert(Step step)
                 steps = Arrays.copyOf(steps, Math.max(i + 1, steps.length * 2));
 
             steps[i] = step;
-            while (--i >= 0 && steps[i] == null) {}
+            while (--i >= 0 && steps[i] == null)

Review Comment:
   Seems that this recently changed https://cassandra.apache.org/_/development/code_style.html
   
   > { and } are placed on a new line except when empty or opening a multi-line lambda expression.
   
   I know there was a new vote/discussion on style changes and didn't keep up... will need to review...
   
   for now ill revert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org