You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2015/10/27 15:07:28 UTC
[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/329
CB-9834 Introduce cordova modules compatibility map for plugin hooks
This fixes potential issue with third-party plugin hooks, since many of them using internal cordova modules, in particular `ConfigParser` and `xml-helpers`.
The sample case is desribed in [CB-9834](https://issues.apache.org/jira/browse/CB-9834)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9834
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #329
----
commit 7e10c4abcb699b2ea7ce5ec5f4c2c53482ef8523
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-10-27T12:20:10Z
CB-9834 Introduce compat map for hook requires
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/329#issuecomment-152495853
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-lib/pull/329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/329#issuecomment-152275664
Closing and reopening to trigger the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-lib/pull/329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/329#issuecomment-152467126
Merged in https://github.com/apache/cordova-lib/commit/b52c257fcde22e982aea7b2287b3d0b943b16df2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/329#issuecomment-152446226
lgtm :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...
Posted by vladimir-kotikov <gi...@git.apache.org>.
GitHub user vladimir-kotikov reopened a pull request:
https://github.com/apache/cordova-lib/pull/329
CB-9834 Introduce cordova modules compatibility map for plugin hooks
This fixes potential issue with third-party plugin hooks, since many of them using internal cordova modules, in particular `ConfigParser` and `xml-helpers`.
The sample case is desribed in [CB-9834](https://issues.apache.org/jira/browse/CB-9834)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9834
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #329
----
commit 7e10c4abcb699b2ea7ce5ec5f4c2c53482ef8523
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-10-27T12:20:10Z
CB-9834 Introduce compat map for hook requires
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org