You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by sravan-s <gi...@git.apache.org> on 2017/03/19 16:13:38 UTC

[GitHub] zeppelin pull request #2160: [ZEPPELIN-1889] Fill missing values to grouped ...

GitHub user sravan-s opened a pull request:

    https://github.com/apache/zeppelin/pull/2160

    [ZEPPELIN-1889] Fill missing values to grouped data

    ### What is this PR for?
    Fix for multiple group in multi-bar chart
    
    If any value is missing under any domain key in stacked multi-bar chart,
    it won't get rendered. Fix this bug by adding `fillMissingValues` flag in
    `d3DataFromPivot()`
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-1889](https://issues.apache.org/jira/browse/ZEPPELIN-1889)
    
    ### How should this be tested?
    * Create a paragraph with tabular output
    * Add multiple groups to input
    * Render the stacked multi bar chart
    * Chart should be rendered properly
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-1889

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2160
    
----
commit a87652ddd71a192795150ae5299f36a178e7f328
Author: ess_ess <sr...@gmail.com>
Date:   2017-03-19T15:52:06Z

    Fill missing values to grouped data
    
    If any value is missing under any domain key in
    stacked multibar chart, chart won't get rendered.
    Fix this bug by adding fillMissingValues flag in
    d3DataFromPivot()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2160: [ZEPPELIN-1889] Fill missing values to grouped ...

Posted by sravan-s <gi...@git.apache.org>.
GitHub user sravan-s reopened a pull request:

    https://github.com/apache/zeppelin/pull/2160

    [ZEPPELIN-1889] Fill missing values to grouped data

    ### What is this PR for?
    Fix for multiple group in multi-bar chart
    
    If any value is missing under any domain key in stacked multi-bar chart,
    it won't get rendered. Fix this bug by adding `fillMissingValues` flag in
    `d3DataFromPivot()`
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-1889](https://issues.apache.org/jira/browse/ZEPPELIN-1889)
    
    ### How should this be tested?
    * Create a paragraph with tabular output
    * Add multiple groups to input
    * Render the stacked multi bar chart
    * Chart should be rendered properly
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-1889

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2160
    
----
commit 44ebbb5b54462a2250c679b24725f3a43f23ef9a
Author: ess_ess <sr...@gmail.com>
Date:   2017-03-19T15:52:06Z

    Fill missing values to grouped data
    
    If any value is missing under any domain key in
    stacked multibar chart, chart won't get rendered
    Fix this bug by adding fillMissingValues flag in
    d3DataFromPivot()

commit 368a50ef12dbda6d499714b1767ea209726381ca
Author: ess_ess <sr...@gmail.com>
Date:   2017-03-20T16:45:43Z

    Merge remote-tracking branch 'mothership/master' into ZEPPELIN-1889

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2160: [ZEPPELIN-1889] Fill missing values to grouped data

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2160
  
    I checked Jenkins log for last commit 368a50e. And looks like Jenkins build script somehow confused with 'merge' and handling it not very well. :-(



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2160: [ZEPPELIN-1889] Fill missing values to grouped ...

Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s closed the pull request at:

    https://github.com/apache/zeppelin/pull/2160


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2160: [ZEPPELIN-1889] Fill missing values to grouped data

Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2160
  
    Sorry, it's my mistake, I did a pull instead of rebase


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2160: [ZEPPELIN-1889] Fill missing values to grouped ...

Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s closed the pull request at:

    https://github.com/apache/zeppelin/pull/2160


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2160: [ZEPPELIN-1889] Fill missing values to grouped data

Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2160
  
    Are there any problems in CI?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2160: [ZEPPELIN-1889] Fill missing values to grouped ...

Posted by sravan-s <gi...@git.apache.org>.
GitHub user sravan-s reopened a pull request:

    https://github.com/apache/zeppelin/pull/2160

    [ZEPPELIN-1889] Fill missing values to grouped data

    ### What is this PR for?
    Fix for multiple group in multi-bar chart
    
    If any value is missing under any domain key in stacked multi-bar chart,
    it won't get rendered. Fix this bug by adding `fillMissingValues` flag in
    `d3DataFromPivot()`
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-1889](https://issues.apache.org/jira/browse/ZEPPELIN-1889)
    
    ### How should this be tested?
    * Create a paragraph with tabular output
    * Add multiple groups to input
    * Render the stacked multi bar chart
    * Chart should be rendered properly
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-1889

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2160
    
----
commit 44ebbb5b54462a2250c679b24725f3a43f23ef9a
Author: ess_ess <sr...@gmail.com>
Date:   2017-03-19T15:52:06Z

    Fill missing values to grouped data
    
    If any value is missing under any domain key in
    stacked multibar chart, chart won't get rendered
    Fix this bug by adding fillMissingValues flag in
    d3DataFromPivot()

commit 368a50ef12dbda6d499714b1767ea209726381ca
Author: ess_ess <sr...@gmail.com>
Date:   2017-03-20T16:45:43Z

    Merge remote-tracking branch 'mothership/master' into ZEPPELIN-1889

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2160: [ZEPPELIN-1889] Fill missing values to grouped ...

Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s closed the pull request at:

    https://github.com/apache/zeppelin/pull/2160


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---