You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/26 01:28:10 UTC

[GitHub] [incubator-kyuubi] wForget commented on pull request #1853: [KYUUBI #1798] Add EventBus module to unify the distribution and subscription of Kyuubi's events

wForget commented on pull request #1853:
URL: https://github.com/apache/incubator-kyuubi/pull/1853#issuecomment-1079550911


   LGTM, in addition, I have some comments:
   1. Why don't we register handlers with `EventBus.registerAsync`?
   2. `SparkJsonLoggingEventHandler` and `ServerJsonLoggingEventHandler` don't seem to do anything, they seem unnecessary.
   3. Do we need to use a separate `ExecutionContext` for EventBus instead of `Implicits.global`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org