[GitHub] [dubbo] zrlw commented on a change in pull request #9273: [3.0] fix #9272, add thread pool info to DataStore

[GitBox <gi...@apache.org>]

zrlw commented on a change in pull request #9273:
URL: https://github.com/apache/dubbo/pull/9273#discussion_r749390260



##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/DefaultExecutorRepository.java
##########
@@ -352,7 +354,11 @@ public ScheduledExecutorService getSharedScheduledExecutor() {
     }
 
     private ExecutorService createExecutor(URL url) {
-        return (ExecutorService) extensionAccessor.getExtensionLoader(ThreadPool.class).getAdaptiveExtension().getExecutor(url);
+        ExecutorService executorService = (ExecutorService) ExtensionLoader.getExtensionLoader(ThreadPool.class).getAdaptiveExtension().getExecutor(url);

Review comment:
       all ```ExtensionLoader.getExtensionLoader``` might be changed to  ```extensionAccessor.getExtensionLoader``` , otherwise it will throws exception at destroyAll.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org