[GitHub] [lucene-solr] ctargett commented on pull request #2227: SOLR-13105 - Visual Guide to Math Expressions

[GitBox <gi...@apache.org>]

ctargett commented on pull request #2227:
URL: https://github.com/apache/lucene-solr/pull/2227#issuecomment-763968623


   > but in this change, it looks like just doing `<<upgrading-solr.adoc#>>.` is enough!
   
   The link format `<<upgrading-solr.adoc#>>` (with an empty anchor) will create valid links when the document is converted to HTML but the `check` task will fail during link validation. It's probably confusing because did one commit that changed a bunch of links to have empty anchors then had to do another one to put the explicit section heading back into the link because the `check` task failed. I'm checking the asciidoctor docs to be sure it is really valid and filing an issue to change the link validator to be less restrictive.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org