You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/12 19:43:01 UTC
[GitHub] [airflow] FloChehab opened a new issue #13643: Improve annotations customization in the chart
FloChehab opened a new issue #13643:
URL: https://github.com/apache/airflow/issues/13643
**Description**
As discussed in https://github.com/apache/airflow/pull/13616#issuecomment-758234146, we would need to improve the customization of annotations across all objects of the chart.
**Use case / motivation**
We often need to paremetrize the annotations and we would rather do it in one PR with all the objects rather than one small PR everytime.
**Are you willing to submit a PR?**
@mik-laj I am ready to be assigned.
**Related Issues**
Not to my knowledge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-758917548
Absolutely a good idea 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-758898326
(I have added more info in the issue description, feel free to it)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-769607113
We have a ticket that improves the annotation handling for SA a bit. Anyone willing to do a review and say if this change is sufficient for this ticket as well?
https://github.com/apache/airflow/pull/11769
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-758896771
**First:**
Objects that should have parametrizable annotations:
* Pod (inside deployment and StatefulSet),
* Service,
* ServiceAccount,
* Ingress.
Is this list too much ? Am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-809774783
@FloChehab awesome! Please let us know when it's ready to review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-774746562
Hello,
Regarding the terminology
> What terminology do we choose in the values.yaml? (annotations or extraAnnotations or both or something else?)
I checked the chart and `extraAnnotations` is only used when there are other annotations related to prometheus that are already present (for the pgbouncer-service & the statsd-service). My position on this would be to remove such annotations related to prometheus and use the `annotations` terminology everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-784482952
Hello, just wanted to let you now that I should have time to work on this issue in couple of weeks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-829022786
Hello, time flies!
I am going to have a quick lool at #15238 ; also, some related work seems to be going on in https://github.com/apache/airflow/pull/14152 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
kaxil closed issue #13643:
URL: https://github.com/apache/airflow/issues/13643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-829737801
@FloChehab sounds good let me know where I can help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-758914504
@dimberman @XD-DENG @potiuk Do you have any thoughts on this? I saw that these changes often come back in different forms, and I think we can do it once, but good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab edited a comment on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
FloChehab edited a comment on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-758898326
(I have added more info in the issue description, feel free to edit)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #13643: Improve annotations customization in the chart
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13643:
URL: https://github.com/apache/airflow/issues/13643#issuecomment-758945570
Absolutely !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org