You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/09 05:04:03 UTC
[GitHub] [incubator-nuttx-website] btashton opened a new pull request #20:
Update contributors list to reflect current status
btashton opened a new pull request #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20
Signed-off-by: Brennan Ashton <ba...@brennanashton.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on a change in
pull request #20: Update contributors list to reflect current status
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20#discussion_r405993957
##########
File path: _data/contributors.yml
##########
@@ -66,6 +66,11 @@
role: PPMC, Committer
org:
+- name: Haitao Liu
Review comment:
Yes, line 69 is right, but line 57 is wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] btashton commented on a change in pull
request #20: Update contributors list to reflect current status
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20#discussion_r405977224
##########
File path: _data/contributors.yml
##########
@@ -66,6 +66,11 @@
role: PPMC, Committer
org:
+- name: Haitao Liu
Review comment:
There is exactly one space between all of the entries. I think it is correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on a change in
pull request #20: Update contributors list to reflect current status
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20#discussion_r406001072
##########
File path: _data/contributors.yml
##########
@@ -66,6 +66,11 @@
role: PPMC, Committer
org:
+- name: Haitao Liu
Review comment:
Sorry, it seem that my browser render the layout a little bit wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] btashton commented on a change in pull
request #20: Update contributors list to reflect current status
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20#discussion_r405997882
##########
File path: _data/contributors.yml
##########
@@ -66,6 +66,11 @@
role: PPMC, Committer
org:
+- name: Haitao Liu
Review comment:
Sorry I'm still not seeing what you are talking about, can you use the suggest an edit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] xiaoxiang781216 edited a comment on issue
#20: Update contributors list to reflect current status
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20#issuecomment-611379960
@btashton the pushlish fail:
```
remote: Permission to apache/incubator-nuttx-website.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/apache/incubator-nuttx-website/': The requested URL returned error: 403
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on a change in
pull request #20: Update contributors list to reflect current status
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20#discussion_r405971469
##########
File path: _data/contributors.yml
##########
@@ -66,6 +66,11 @@
role: PPMC, Committer
org:
+- name: Haitao Liu
Review comment:
Should we remove the extra space before "Flavio Paiva Junqueira" at line 57?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on issue #20:
Update contributors list to reflect current status
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20#issuecomment-611379960
@btashton the pushlish fail:
remote: Permission to apache/incubator-nuttx-website.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/apache/incubator-nuttx-website/': The requested URL returned error: 403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] btashton commented on issue #20: Update
contributors list to reflect current status
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20#issuecomment-611859545
@xiaoxiang781216 this should be resolved with #21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] xiaoxiang781216 merged pull request #20:
Update contributors list to reflect current status
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-website] btashton commented on issue #20: Update
contributors list to reflect current status
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #20: Update contributors list to reflect current status
URL: https://github.com/apache/incubator-nuttx-website/pull/20#issuecomment-611512825
Thanks I'll fix it tonight. The publish needs to be triggered by the push to master or it won't have the correct permissions.
https://help.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token#permissions-for-the-github_token
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services