You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2023/01/16 02:55:39 UTC
[GitHub] [ozone] ChenSammi opened a new pull request, #4177: HDDS-7783. Add platform info in 'ozone version' command output.
ChenSammi opened a new pull request, #4177:
URL: https://github.com/apache/ozone/pull/4177
https://issues.apache.org/jira/browse/HDDS-7783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #4177: HDDS-7783. Add compile platform info in 'ozone version' command output
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #4177:
URL: https://github.com/apache/ozone/pull/4177#issuecomment-1396600099
@tanvipenumudy can you please take a look as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a diff in pull request #4177: HDDS-7783. Add platform info in 'ozone version' command output.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #4177:
URL: https://github.com/apache/ozone/pull/4177#discussion_r1071191040
##########
hadoop-hdds/common/src/main/resources/hdds-version-info.properties:
##########
@@ -25,4 +25,5 @@ url=${version-info.scm.uri}
srcChecksum=${version-info.source.md5}
hadoopProtoc2Version=${proto2.hadooprpc.protobuf.version}
hadoopProtoc3Version=${proto3.hadooprpc.protobuf.version}
-grpcProtocVersion=${grpc.protobuf-compile.version}
\ No newline at end of file
+grpcProtocVersion=${grpc.protobuf-compile.version}
+platform=${os.detected.classifier}
Review Comment:
Yes, the value is from the below platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #4177: HDDS-7783. Add compile platform info in 'ozone version' command output
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #4177:
URL: https://github.com/apache/ozone/pull/4177#issuecomment-1415490504
>
> I am also curious where it would be useful, like do we have some native changes like which are OS/Arch dependent?
Hi @ayushtkn, it is just a piece of trivial and interesting info about the compiled platform, not related with any arch dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4177: HDDS-7783. Add compile platform info in 'ozone version' command output
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4177:
URL: https://github.com/apache/ozone/pull/4177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on a diff in pull request #4177: HDDS-7783. Add platform info in 'ozone version' command output.
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #4177:
URL: https://github.com/apache/ozone/pull/4177#discussion_r1070910015
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/HddsVersionInfo.java:
##########
@@ -52,6 +52,8 @@ public static void main(String[] args) {
" and " + HDDS_VERSION_INFO.getHadoopProtoc3Version());
System.out.println(
"From source with checksum " + HDDS_VERSION_INFO.getSrcChecksum());
+ System.out.println(
+ "For platform " + HDDS_VERSION_INFO.getPlatform());
Review Comment:
Correct me if I'm wrong, I don't think the current Ozone binary package is platform specific.
If I'm correct, we should give information like "compiled on x86_64", but not "compiled for x86_64".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on a diff in pull request #4177: HDDS-7783. Add platform info in 'ozone version' command output.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on code in PR #4177:
URL: https://github.com/apache/ozone/pull/4177#discussion_r1071193297
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/HddsVersionInfo.java:
##########
@@ -52,6 +52,8 @@ public static void main(String[] args) {
" and " + HDDS_VERSION_INFO.getHadoopProtoc3Version());
System.out.println(
"From source with checksum " + HDDS_VERSION_INFO.getSrcChecksum());
+ System.out.println(
+ "For platform " + HDDS_VERSION_INFO.getPlatform());
Review Comment:
Right, "compiled on" is an accurate wording.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on a diff in pull request #4177: HDDS-7783. Add platform info in 'ozone version' command output.
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #4177:
URL: https://github.com/apache/ozone/pull/4177#discussion_r1070908573
##########
hadoop-hdds/common/src/main/resources/hdds-version-info.properties:
##########
@@ -25,4 +25,5 @@ url=${version-info.scm.uri}
srcChecksum=${version-info.source.md5}
hadoopProtoc2Version=${proto2.hadooprpc.protobuf.version}
hadoopProtoc3Version=${proto3.hadooprpc.protobuf.version}
-grpcProtocVersion=${grpc.protobuf-compile.version}
\ No newline at end of file
+grpcProtocVersion=${grpc.protobuf-compile.version}
+platform=${os.detected.classifier}
Review Comment:
Looks like this value is defined in compile time.
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/HddsVersionInfo.java:
##########
@@ -52,6 +52,8 @@ public static void main(String[] args) {
" and " + HDDS_VERSION_INFO.getHadoopProtoc3Version());
System.out.println(
"From source with checksum " + HDDS_VERSION_INFO.getSrcChecksum());
+ System.out.println(
+ "For platform " + HDDS_VERSION_INFO.getPlatform());
Review Comment:
Correct me if I'm wrong, I don't think the current Ozone binary package is platform specific.
If it's true, we should give information like "compiled on x86_64", but not "compiled for x86_64".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4177: HDDS-7783. Add compile platform info in 'ozone version' command output
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #4177:
URL: https://github.com/apache/ozone/pull/4177#issuecomment-1384493340
Thanks @ChenSammi for the patch.
> https://issues.apache.org/jira/browse/HDDS-7783
Can you please add a description to the PR or the Jira issue, explaining why the platform info is needed? The PR has no description, only a link to the task, which has no description either, so it's hard to tell what's the goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #4177: HDDS-7783. Add compile platform info in 'ozone version' command output
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4177:
URL: https://github.com/apache/ozone/pull/4177#issuecomment-1415806799
Thanks @ChenSammi for the patch, @ayushtkn, @kaijchen for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org