You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2023/01/13 07:37:06 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1120: `HrangebyLex` supports specify intervals

PragmaTwice commented on code in PR #1120:
URL: https://github.com/apache/incubator-kvrocks/pull/1120#discussion_r1069035327


##########
src/types/redis_hash.cc:
##########
@@ -355,4 +383,36 @@ rocksdb::Status Hash::Scan(const Slice &user_key, const std::string &cursor, uin
   return SubKeyScanner::Scan(kRedisHash, user_key, cursor, limit, field_prefix, fields, values);
 }
 
+Status Hash::ParseRangeLexSpec(const std::string &min, const std::string &max, CommonRangeLexSpec *spec) {

Review Comment:
   Could you move the function to range_spec.cc, so it can be reused in zset and hash?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org