You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2025/05/06 15:01:27 UTC
[PR] Rat adjustments based on grails-forge PR feedback [grails-core]
jamesfredley opened a new pull request, #14715:
URL: https://github.com/apache/grails-core/pull/14715
- Remove permission that is defaulted
- Make rat task lazily configured
Based on feedback from https://github.com/apache/grails-forge/pull/562, which started with copies of the same files from grails-core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rat adjustments based on grails-forge PR feedback [grails-core]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #14715:
URL: https://github.com/apache/grails-core/pull/14715#discussion_r2075697594
##########
gradle/rat-root-config.gradle:
##########
@@ -17,8 +17,8 @@
apply plugin: 'org.nosphere.apache.rat'
-tasks.named('rat') {
- excludes = [
+tasks.named('rat').configure {
Review Comment:
Please revert this again. According to my tests today it should not be needed. Sorry about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rat adjustments based on grails-forge PR feedback [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #14715:
URL: https://github.com/apache/grails-core/pull/14715#discussion_r2075949825
##########
gradle/rat-root-config.gradle:
##########
@@ -17,8 +17,8 @@
apply plugin: 'org.nosphere.apache.rat'
-tasks.named('rat') {
- excludes = [
+tasks.named('rat').configure {
Review Comment:
I removed the commit with `.configure {}` before merging this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rat adjustments based on grails-forge PR feedback [grails-core]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #14715:
URL: https://github.com/apache/grails-core/pull/14715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org