You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/09 04:55:33 UTC
[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5672: Add SelectionQuerySegmentPruner to prune segments for simple selection queries
Jackie-Jiang opened a new pull request #5672:
URL: https://github.com/apache/incubator-pinot/pull/5672
- For selection query with LIMIT 0, keep 1 segment to create the data schema
- For selection only query without filter, keep enough documents to fulfill the LIMIT requirement
- For selection order-by query without filter, if the first order-by expression is an identifier (column), prune segments based on the column min/max value and keep enough documents to fulfill the LIMIT and OFFSET requirement
## Description
Add a description of your PR here.
A good description should include pointers to an issue or design document, etc.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
## Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #5672: Add SelectionQuerySegmentPruner to prune segments for simple selection queries
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #5672:
URL: https://github.com/apache/incubator-pinot/pull/5672#issuecomment-658223930
> > Does the `LIMIT 0` query response just contains the projected columns or all columns from schema? If so, do we even need one segment there? We can simply refer to the schema for columns and data types?
>
> @mayankshriv `LIMIT 0` query might contain columns and transform functions. So we still need to keep one segment to construct the TransformOperator in order to get all column types. No actual data fetch is required for that single segment.
@Jackie-Jiang Since we don't enforce schema to be same across segments, wouldn't it be better to have a Schema based operator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5672: Add SelectionQuerySegmentPruner to prune segments for simple selection queries
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on pull request #5672:
URL: https://github.com/apache/incubator-pinot/pull/5672#issuecomment-656960636
> Does the `LIMIT 0` query response just contains the projected columns or all columns from schema? If so, do we even need one segment there? We can simply refer to the schema for columns and data types?
@mayankshriv `LIMIT 0` query might contain columns and transform functions. So we still need to keep one segment to construct the TransformOperator in order to get all column types. No actual data fetch is required for that single segment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5672: Add SelectionQuerySegmentPruner to prune segments for simple selection queries
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on pull request #5672:
URL: https://github.com/apache/incubator-pinot/pull/5672#issuecomment-658316154
> > > Does the `LIMIT 0` query response just contains the projected columns or all columns from schema? If so, do we even need one segment there? We can simply refer to the schema for columns and data types?
> >
> >
> > @mayankshriv `LIMIT 0` query might contain columns and transform functions. So we still need to keep one segment to construct the TransformOperator in order to get all column types. No actual data fetch is required for that single segment.
>
> @Jackie-Jiang Since we don't enforce schema to be same across segments, wouldn't it be better to have a Schema based operator (perhaps fall back to segment if schema not registered)?
@mayankshriv Ideally `LIMIT 0` query should be able to be solved on broker side (where the Schema based operator should be added), but that is out of the scope of this PR. Once we enforce schema, we can add that to avoid the routing overhead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5672: Add SelectionQuerySegmentPruner to prune segments for simple selection queries
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #5672:
URL: https://github.com/apache/incubator-pinot/pull/5672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #5672: Add SelectionQuerySegmentPruner to prune segments for simple selection queries
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #5672:
URL: https://github.com/apache/incubator-pinot/pull/5672#issuecomment-656919360
Does the `LIMIT 0` query response just contains the projected columns or all columns from schema? If so, do we even need one segment there? We can simply refer to the schema for columns and data types?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv edited a comment on pull request #5672: Add SelectionQuerySegmentPruner to prune segments for simple selection queries
Posted by GitBox <gi...@apache.org>.
mayankshriv edited a comment on pull request #5672:
URL: https://github.com/apache/incubator-pinot/pull/5672#issuecomment-658223930
> > Does the `LIMIT 0` query response just contains the projected columns or all columns from schema? If so, do we even need one segment there? We can simply refer to the schema for columns and data types?
>
> @mayankshriv `LIMIT 0` query might contain columns and transform functions. So we still need to keep one segment to construct the TransformOperator in order to get all column types. No actual data fetch is required for that single segment.
@Jackie-Jiang Since we don't enforce schema to be same across segments, wouldn't it be better to have a Schema based operator (perhaps fall back to segment if schema not registered)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org