You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Nataneljpwd (via GitHub)" <gi...@apache.org> on 2026/09/11 16:30:37 UTC
[PR] [chart/v1-2x-test] Fix Helm Chart regression with Kerberos in Kuberne… [airflow]
Nataneljpwd opened a new pull request, #72984:
URL: https://github.com/apache/airflow/pull/72984
…tes (#70688)
* fixed helm chart regression with kerberos
* done for kubernetes executor as well
* moved the value around
* address cr comments
* changed the tests
* added tests
* fixed typo
* fix tests
* fixed tests
* fixed the tests
* fixed failing test
---------
(cherry picked from commit 3817ee64acaac138baf574f80656bc5cd1fcda77)
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [chart/v1-2x-test] Fix Helm Chart regression with Kerberos in Kuberne… [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on code in PR #72984:
URL: https://github.com/apache/airflow/pull/72984#discussion_r4098906852
##########
chart/values.yaml:
##########
@@ -1775,6 +1778,9 @@ workers:
# Container level lifecycle hooks
containerLifecycleHooks: {}
+ # Should the kerberos-ccache mount be readonly for Celery Workers
Review Comment:
Thanks - related PR on main merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [chart/v1-2x-test] Fix Helm Chart regression with Kerberos in Kubernetes (#70688) [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on PR #72984:
URL: https://github.com/apache/airflow/pull/72984#issuecomment-5822947123
I fixed the PR title, so just for the future, just take a closer look if it might be refined a bit. Unfortunately, GitHub cuts some parts if it is too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [chart/v1-2x-test] Fix Helm Chart regression with Kerberos in Kuberne… [airflow]
Posted by "Nataneljpwd (via GitHub)" <gi...@apache.org>.
Nataneljpwd commented on code in PR #72984:
URL: https://github.com/apache/airflow/pull/72984#discussion_r4095800305
##########
chart/values.yaml:
##########
@@ -1775,6 +1778,9 @@ workers:
# Container level lifecycle hooks
containerLifecycleHooks: {}
+ # Should the kerberos-ccache mount be readonly for Celery Workers
Review Comment:
I will check if it appears on main and fix it there as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [chart/v1-2x-test] Fix Helm Chart regression with Kerberos in Kubernetes (#70688) [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl merged PR #72984:
URL: https://github.com/apache/airflow/pull/72984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [chart/v1-2x-test] Fix Helm Chart regression with Kerberos in Kuberne… [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on code in PR #72984:
URL: https://github.com/apache/airflow/pull/72984#discussion_r3992800621
##########
chart/values.yaml:
##########
@@ -1775,6 +1778,9 @@ workers:
# Container level lifecycle hooks
containerLifecycleHooks: {}
+ # Should the kerberos-ccache mount be readonly for Celery Workers
Review Comment:
This one is for pod-template-file, not Celery Workers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [chart/v1-2x-test] Fix Helm Chart regression with Kerberos in Kuberne… [airflow]
Posted by "Nataneljpwd (via GitHub)" <gi...@apache.org>.
Nataneljpwd commented on code in PR #72984:
URL: https://github.com/apache/airflow/pull/72984#discussion_r4095798175
##########
chart/values.yaml:
##########
@@ -1775,6 +1778,9 @@ workers:
# Container level lifecycle hooks
containerLifecycleHooks: {}
+ # Should the kerberos-ccache mount be readonly for Celery Workers
Review Comment:
oops, correct, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org