You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/23 11:00:21 UTC
[GitHub] [flink] zentol opened a new pull request #11192:
[FLINK-16237][build] Add Log4j2 configuration properties
zentol opened a new pull request #11192: [FLINK-16237][build] Add Log4j2 configuration properties
URL: https://github.com/apache/flink/pull/11192
The property for configuration the log4j filepath has changed after switching to Log4j2 (from `log4j.configuration` to `log4j.configurationFile`).
All production scripts/utils must be adjusted to specify both properties to retain Log4j1 support.
In testing code we only refer to `configurationFile` naturally, as we only use Log4j2 here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #11192: [FLINK-16237][build] Add
Log4j2 configuration properties
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11192: [FLINK-16237][build] Add Log4j2 configuration properties
URL: https://github.com/apache/flink/pull/11192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11192:
[FLINK-16237][build] Add Log4j2 configuration properties
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11192: [FLINK-16237][build] Add Log4j2 configuration properties
URL: https://github.com/apache/flink/pull/11192#issuecomment-590057592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150192648",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f7c881ff76ad638a06c706b03a996364569c3c6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150192648)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11192: [FLINK-16237][build]
Add Log4j2 configuration properties
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11192: [FLINK-16237][build] Add Log4j2 configuration properties
URL: https://github.com/apache/flink/pull/11192#issuecomment-590056458
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0f7c881ff76ad638a06c706b03a996364569c3c6 (Sun Feb 23 11:02:06 UTC 2020)
**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11192:
[FLINK-16237][build] Add Log4j2 configuration properties
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11192: [FLINK-16237][build] Add Log4j2 configuration properties
URL: https://github.com/apache/flink/pull/11192#issuecomment-590057592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150192648",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
}, {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5479",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
}, {
"hash" : "6500c5170375b837320f00a032d64a7eec69135d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150225021",
"triggerID" : "6500c5170375b837320f00a032d64a7eec69135d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6500c5170375b837320f00a032d64a7eec69135d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150225021)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11192:
[FLINK-16237][build] Add Log4j2 configuration properties
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11192: [FLINK-16237][build] Add Log4j2 configuration properties
URL: https://github.com/apache/flink/pull/11192#issuecomment-590057592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150192648",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
}, {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5479",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f7c881ff76ad638a06c706b03a996364569c3c6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150192648) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11192:
[FLINK-16237][build] Add Log4j2 configuration properties
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11192: [FLINK-16237][build] Add Log4j2 configuration properties
URL: https://github.com/apache/flink/pull/11192#issuecomment-590057592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150192648",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
}, {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5479",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
}, {
"hash" : "6500c5170375b837320f00a032d64a7eec69135d",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150225021",
"triggerID" : "6500c5170375b837320f00a032d64a7eec69135d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f7c881ff76ad638a06c706b03a996364569c3c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150192648) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5479)
* 6500c5170375b837320f00a032d64a7eec69135d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150225021)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11192:
[FLINK-16237][build] Add Log4j2 configuration properties
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11192: [FLINK-16237][build] Add Log4j2 configuration properties
URL: https://github.com/apache/flink/pull/11192#issuecomment-590057592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150192648",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
}, {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5479",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f7c881ff76ad638a06c706b03a996364569c3c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150192648) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5479)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11192: [FLINK-16237][build]
Add Log4j2 configuration properties
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11192: [FLINK-16237][build] Add Log4j2 configuration properties
URL: https://github.com/apache/flink/pull/11192#issuecomment-590057592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f7c881ff76ad638a06c706b03a996364569c3c6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11192:
[FLINK-16237][build] Add Log4j2 configuration properties
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11192: [FLINK-16237][build] Add Log4j2 configuration properties
URL: https://github.com/apache/flink/pull/11192#issuecomment-590057592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150192648",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
}, {
"hash" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5479",
"triggerID" : "0f7c881ff76ad638a06c706b03a996364569c3c6",
"triggerType" : "PUSH"
}, {
"hash" : "6500c5170375b837320f00a032d64a7eec69135d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6500c5170375b837320f00a032d64a7eec69135d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0f7c881ff76ad638a06c706b03a996364569c3c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150192648) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5479)
* 6500c5170375b837320f00a032d64a7eec69135d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services