[GitHub] [calcite] vlsi commented on a change in pull request #1766: [CALCITE-3745] UnitCompiler can not find required class information.

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #1766:
URL: https://github.com/apache/calcite/pull/1766#discussion_r584623885



##########
File path: core/src/main/java/org/apache/calcite/util/javac/CalciteCompilerArgs.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.util.javac;
+
+/**
+ * A <code>CalciteCompilerArgs</code> holds the arguments for a
+ * {@link org.codehaus.janino.SimpleCompiler} and its sub classes.
+ *
+ */
+public class CalciteCompilerArgs {
+
+  public static final CalciteCompilerArgs DEFAULT = new CalciteCompilerArgs();
+
+  private ClassLoader classLoader = CalciteCompilerArgs.class.getClassLoader();
+
+  public void setClassLoader(ClassLoader classLoader) {
+    if (classLoader != null) {
+      this.classLoader = classLoader;
+    }

Review comment:
       Please, no. "shared mutable state" is not how Calcite is configured.
   It looks like the classloader should be an extra argument to `RexExecutable` constructor or something like that




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org