[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6845: [WIP] plugins: Add non strict affinity groups

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6845:
URL: https://github.com/apache/cloudstack/pull/6845#discussion_r1004440508


##########
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java:
##########
@@ -406,7 +410,7 @@ public DeployDestination planDeployment(VirtualMachineProfile vmProfile, Deploym
             planner = getDeploymentPlannerByName(plannerName);
         }
 
-        if (vm.getLastHostId() != null && haVmTag == null) {
+        if (vm.getLastHostId() != null && haVmTag == null && !forgetLastHostBool) {

Review Comment:
   maybe extract this conditional block as `considerLastHost(...)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org