You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/08/31 00:08:52 UTC
Re: Review Request 60593: Added `network/ports` isolator recovery
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60593/
-----------------------------------------------------------
(Updated Aug. 31, 2017, 12:08 a.m.)
Review request for mesos, Qian Zhang and Jiang Yan Xu.
Summary (updated)
-----------------
Added `network/ports` isolator recovery tests.
Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675
Repository: mesos
Description
-------
Added a test for the `network/ports` isolator recovery by starting
a task that is listening on a rogue port. We only configure the
isolator when we restart the agent to simulate the case where a
task only starts to misbehave after an agent recovery.
Diffs (updated)
-----
src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/60593/diff/14/
Changes: https://reviews.apache.org/r/60593/diff/13-14/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 60593: Added `network/ports` isolator recovery
tests.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60593/#review184663
-----------------------------------------------------------
src/tests/containerizer/ports_isolator_tests.cpp
Lines 784 (patched)
<https://reviews.apache.org/r/60593/#comment260856>
I think we need to enable the `network/ports` isolator when the agent is restarted (just like what you did for `NetworkPortsIsolatorTest.ROOT_NC_RecoverNestedGoodTask`) rather than when the agent is started for the first time.
- Qian Zhang
On Aug. 31, 2017, 8:08 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60593/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2017, 8:08 a.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for the `network/ports` isolator recovery by starting
> a task that is listening on a rogue port. We only configure the
> isolator when we restart the agent to simulate the case where a
> task only starts to misbehave after an agent recovery.
>
>
> Diffs
> -----
>
> src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60593/diff/14/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60593: Added `network/ports` isolator recovery
tests.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60593/#review184960
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Sept. 8, 2017, 5:57 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60593/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2017, 5:57 a.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for the `network/ports` isolator recovery by starting
> a task that is listening on a rogue port. We only configure the
> isolator when we restart the agent to simulate the case where a
> task only starts to misbehave after an agent recovery.
>
>
> Diffs
> -----
>
> src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60593/diff/16/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60593: Added `network/ports` isolator recovery
tests.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60593/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 7:14 p.m.)
Review request for mesos, Qian Zhang and Jiang Yan Xu.
Changes
-------
Updated nested container status update checks.
Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675
Repository: mesos
Description
-------
Added a test for the `network/ports` isolator recovery by starting
a task that is listening on a rogue port. We only configure the
isolator when we restart the agent to simulate the case where a
task only starts to misbehave after an agent recovery.
Diffs (updated)
-----
src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/60593/diff/18/
Changes: https://reviews.apache.org/r/60593/diff/17-18/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 60593: Added `network/ports` isolator recovery
tests.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60593/
-----------------------------------------------------------
(Updated Sept. 7, 2017, 9:57 p.m.)
Review request for mesos, Qian Zhang and Jiang Yan Xu.
Changes
-------
Rebase and address review feedback.
Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675
Repository: mesos
Description
-------
Added a test for the `network/ports` isolator recovery by starting
a task that is listening on a rogue port. We only configure the
isolator when we restart the agent to simulate the case where a
task only starts to misbehave after an agent recovery.
Diffs (updated)
-----
src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/60593/diff/15/
Changes: https://reviews.apache.org/r/60593/diff/14-15/
Testing
-------
make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 60593: Added `network/ports` isolator recovery
tests.
Posted by James Peach <jp...@apache.org>.
> On Sept. 6, 2017, 12:19 p.m., Qian Zhang wrote:
> > src/tests/containerizer/ports_isolator_tests.cpp
> > Lines 741 (patched)
> > <https://reviews.apache.org/r/60593/diff/14/?file=1808286#file1808286line741>
> >
> > Why do we need to explicitly set this flag to such a large number?
I ended up removing this altogether. It is not necessary and setting it too high makes recovery tests flaky.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60593/#review184657
-----------------------------------------------------------
On Aug. 31, 2017, 12:08 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60593/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2017, 12:08 a.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for the `network/ports` isolator recovery by starting
> a task that is listening on a rogue port. We only configure the
> isolator when we restart the agent to simulate the case where a
> task only starts to misbehave after an agent recovery.
>
>
> Diffs
> -----
>
> src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60593/diff/14/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60593: Added `network/ports` isolator recovery
tests.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60593/#review184657
-----------------------------------------------------------
src/tests/containerizer/ports_isolator_tests.cpp
Lines 704-706 (patched)
<https://reviews.apache.org/r/60593/#comment260845>
These 3 lines can be merged into 2 lines.
src/tests/containerizer/ports_isolator_tests.cpp
Lines 741 (patched)
<https://reviews.apache.org/r/60593/#comment260848>
Why do we need to explicitly set this flag to such a large number?
- Qian Zhang
On Aug. 31, 2017, 8:08 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60593/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2017, 8:08 a.m.)
>
>
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
>
>
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for the `network/ports` isolator recovery by starting
> a task that is listening on a rogue port. We only configure the
> isolator when we restart the agent to simulate the case where a
> task only starts to misbehave after an agent recovery.
>
>
> Diffs
> -----
>
> src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60593/diff/14/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>