[GitHub] ScienJus opened a new issue #1881: Override default config by agent arguments

[GitBox <gi...@apache.org>]

ScienJus opened a new issue #1881: Override default config by agent arguments
URL: https://github.com/apache/incubator-skywalking/issues/1881
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [x] Feature or performance improvement
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.
   
   We use docker to deploy multiple java applications on each host. so we put the skywalking agent on the host and mount it to every container.
   
   Each application has it's unique `application_code`, but they share the same agent jar and config file, so we need a more flexible config.
   
   I noticed that skywalking already supports overriding the default config by system properties, I suggest that also add agent arguments(or options?) support, which is something just like `-javaagent:jarpath[=options]`.
   
   In this way, not only we can overriding default config, but also more compact:
   
   ```
   -javaagent:/path/to/skywalking/agent.jar=agent.application_code=backend
   ```
   
   Finally, it's easy to implement, just parse the `agentArgs` parameter in `SkyWalkingAgent#premain`.
   
   
   I‘d like to create a pull request if you agree with this optimization.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services