You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2021/07/09 13:31:30 UTC
[GitHub] [tinkerpop] FlorianHockmann opened a new pull request #1448: Fix Python build by pinning peer dependency packaging to 20.9
FlorianHockmann opened a new pull request #1448:
URL: https://github.com/apache/tinkerpop/pull/1448
The Python build is currently broken which is apparently caused by this peer dependency in version 21.
Pinning it to 20.9 seems to fix the build.
We can remove this pinning later when the problem is gone (so the builds goes through without this pinning) or when we drop 3.4-dev as the problem seems to be limited to that branch (probably Python 2).
I think we get this dependency through our dependency on `importlib-metadata` which is why I added the dependency before that package.
This could have been a CTR commit but I wasn't sure if this is the right way to solve this.
@spmallette Feel free to merge this if you agree with this change.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1448: Fix Python build by pinning peer dependency packaging to 20.9
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1448:
URL: https://github.com/apache/tinkerpop/pull/1448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1448: Fix Python build by pinning peer dependency packaging to 20.9
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1448:
URL: https://github.com/apache/tinkerpop/pull/1448#issuecomment-877221086
This builds for me and gets me past the build problems. Note that I believe this is a python2 issue only so I don't think you need to this change in 3.5-dev. I merged the commit to 3.5-dev with `--strategy-ours` and in essence did not apply the change there or master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org