You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by pn...@apache.org on 2023/01/27 11:00:57 UTC
[flink] 01/03: [FLINK-15550][runtime] Revert "Debug logging for TaskTest"
This is an automated email from the ASF dual-hosted git repository.
pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit c9ce64aef00e3cc187937f9fce0d1c34a3dcd166
Author: Anton Kalashnikov <ak...@gmail.com>
AuthorDate: Thu Jan 26 14:35:20 2023 +0100
[FLINK-15550][runtime] Revert "Debug logging for TaskTest"
This reverts commit 16e9b7325881b45741f3591f73a7b7bcfd39322b.
---
.../apache/flink/runtime/taskmanager/TaskTest.java | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
index 95265af8f3c..fd925ec60b2 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
@@ -60,8 +60,6 @@ import org.junit.Before;
import org.junit.ClassRule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import javax.annotation.Nonnull;
@@ -119,11 +117,6 @@ public class TaskTest extends TestLogger {
public void setup() {
awaitLatch = new OneShotLatch();
triggerLatch = new OneShotLatch();
- // Logging is only for debugging FLINK-15550.
- log.info(
- "Preparing trigger latch, {}, isTriggered = {}",
- triggerLatch,
- triggerLatch.isTriggered());
shuffleEnvironment = new NettyShuffleEnvironmentBuilder().build();
wasCleanedUp = false;
@@ -675,7 +668,6 @@ public class TaskTest extends TestLogger {
awaitLatch.await();
task.failExternally(new Exception("external"));
- assertFalse(triggerLatch.isTriggered());
assertEquals(ExecutionState.FAILED, task.getExecutionState());
// Either we cause the CancelTaskException or the TaskCanceler
@@ -1469,23 +1461,13 @@ public class TaskTest extends TestLogger {
/** {@link AbstractInvokable} which throws {@link CancelTaskException} on invoke. */
public static final class InvokableWithCancelTaskExceptionInInvoke extends AbstractInvokable {
- static final Logger LOG = LoggerFactory.getLogger(InvokableWithExceptionOnTrigger.class);
-
public InvokableWithCancelTaskExceptionInInvoke(Environment environment) {
super(environment);
}
@Override
public void invoke() {
- // Logging and try-catch block are only for debugging FLINK-15550.
- LOG.info("Await for {}, isTriggered = {}", triggerLatch, triggerLatch.isTriggered());
- try {
- awaitTriggerLatch();
- } catch (Throwable ex) {
- LOG.error("Fail on awaiting trigger latch", ex);
-
- throw ex;
- }
+ awaitTriggerLatch();
throw new CancelTaskException();
}