You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-user@jakarta.apache.org by "J. B. Rainsberger" <jb...@rogers.com> on 2004/03/05 23:50:19 UTC
Cactus/test name is null
Ron Roth wrote:
> That did the trick. Thanks very much to both of you.
It points out a potential defect in Cactus, though. When the test name
is null, JUnit usually pukes; but in this case, it looks like a test
failure. Vince... maybe it's worth changing Cactus so that it blows up
the same way that JUnit does when the test name is null.
--
J. B. Rainsberger,
Diaspar Software Services
http://www.diasparsoftware.com :: +1 416 791-8603
Let's write software that people understand
RE: Cactus/test name is null
Posted by Vincent Massol <vm...@pivolis.com>.
> -----Original Message-----
> From: Kazuhito SUGURI [mailto:suguri.kazuhito@lab.ntt.co.jp]
> Sent: 15 March 2004 12:39
> To: cactus-user@jakarta.apache.org
> Subject: Re: Cactus/test name is null
>
> Hi,
>
> In article <0d...@vma>,
> Fri, 12 Mar 2004 09:43:28 +0100,
> "Vincent Massol" <vm...@pivolis.com> wrote:
> vmassol> What would be excellent is if you could also provide some
test
> cases
> vmassol> proving that it works. You can either reuse an existing test
case
> class
> vmassol> if it makes sense or create a new one. That will enrich our
test
> suite
> vmassol> and not lower our test coverage! :-)
>
> I'll post the patch and test cases to cactus-dev ML, soon.
Thanks so much Kazuhito!
-Vincent
>
> Regards,
> ----
> Kazuhito SUGURI
> mailto:suguri.kazuhito@lab.ntt.co.jp
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cactus-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: cactus-user-help@jakarta.apache.org
Re: Cactus/test name is null
Posted by Kazuhito SUGURI <su...@lab.ntt.co.jp>.
Hi,
In article <0d...@vma>,
Fri, 12 Mar 2004 09:43:28 +0100,
"Vincent Massol" <vm...@pivolis.com> wrote:
vmassol> What would be excellent is if you could also provide some test cases
vmassol> proving that it works. You can either reuse an existing test case class
vmassol> if it makes sense or create a new one. That will enrich our test suite
vmassol> and not lower our test coverage! :-)
I'll post the patch and test cases to cactus-dev ML, soon.
Regards,
----
Kazuhito SUGURI
mailto:suguri.kazuhito@lab.ntt.co.jp
RE: Cactus/test name is null
Posted by Vincent Massol <vm...@pivolis.com>.
Very cool. Thanks Kazuhito.
What would be excellent is if you could also provide some test cases
proving that it works. You can either reuse an existing test case class
if it makes sense or create a new one. That will enrich our test suite
and not lower our test coverage! :-)
I've had a brief look at the patch. It looks good. Maybe, as a second
step, it would be good to factorize both your check and the ones that
already exist into a single place. ATM, there are lots of checks in the
ClientTestCaseCaller.callGeneric*Method(...)
It would be excellent if all the checks could be gathered in one place.
<future idea>
I've always had the idea of creating AspectJ aspects that will verify
that of the environment in which the Cactus framework executes in order
to verify everything is setup correctly. That could include verifying
test cases are written correctly too. The reason for an aspect is that
these checks have to happen in lots of different locations but they are
implementing the same concern:
- they are not code that deliver a business result
- they are checking environment health
- they know how to deal with errors
Thus I think it makes an excellent candidate for some aspects.
</future idea>
Thanks!
-Vincent
> -----Original Message-----
> From: Kazuhito SUGURI [mailto:suguri.kazuhito@lab.ntt.co.jp]
> Sent: 12 March 2004 04:46
> To: cactus-user@jakarta.apache.org; vmassol@pivolis.com
> Subject: Re: Cactus/test name is null
>
> Hi Vincent,
>
> In article <01...@vma>,
> Sat, 6 Mar 2004 08:40:25 +0100,
> "Vincent Massol" <vm...@pivolis.com> wrote:
> vmassol> Yep, I had the same thought. Also cactus could check for the
> static
> vmassol> keyword in testXXX. Just need to find some time. If anyone
wants
> to
> vmassol> submit a patch...
>
> I had some time yesterday.
>
> Appending is a patch against AbstractCactusTestCase.java, v 1.7.
> I'm not sure if its feature is what you are looking for.
>
> Also, I'm not sure why the static keyword check is needed.
> Would you mind explaining a little further, please?
> # better to change cactus-dev ML?
>
> Regards,
> ----
> Kazuhito SUGURI
> mailto:suguri.kazuhito@lab.ntt.co.jp
Re: Cactus/test name is null
Posted by Kazuhito SUGURI <su...@lab.ntt.co.jp>.
Hi Vincent,
In article <01...@vma>,
Sat, 6 Mar 2004 08:40:25 +0100,
"Vincent Massol" <vm...@pivolis.com> wrote:
vmassol> Yep, I had the same thought. Also cactus could check for the static
vmassol> keyword in testXXX. Just need to find some time. If anyone wants to
vmassol> submit a patch...
I had some time yesterday.
Appending is a patch against AbstractCactusTestCase.java, v 1.7.
I'm not sure if its feature is what you are looking for.
Also, I'm not sure why the static keyword check is needed.
Would you mind explaining a little further, please?
# better to change cactus-dev ML?
Regards,
----
Kazuhito SUGURI
mailto:suguri.kazuhito@lab.ntt.co.jp
RE: Cactus/test name is null
Posted by Vincent Massol <vm...@pivolis.com>.
Yep, I had the same thought. Also cactus could check for the static
keyword in testXXX. Just need to find some time. If anyone wants to
submit a patch...
Thanks
-Vincent
> -----Original Message-----
> From: J. B. Rainsberger [mailto:jbrains@rogers.com]
> Sent: 05 March 2004 23:50
> To: Cactus Users List
> Subject: Cactus/test name is null
>
> Ron Roth wrote:
>
> > That did the trick. Thanks very much to both of you.
>
> It points out a potential defect in Cactus, though. When the test name
> is null, JUnit usually pukes; but in this case, it looks like a test
> failure. Vince... maybe it's worth changing Cactus so that it blows up
> the same way that JUnit does when the test name is null.
> --
> J. B. Rainsberger,
> Diaspar Software Services
> http://www.diasparsoftware.com :: +1 416 791-8603
> Let's write software that people understand
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cactus-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: cactus-user-help@jakarta.apache.org