[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads

["Anoop Sam John (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917372#comment-16917372 ] 

Anoop Sam John commented on HBASE-22930:
----------------------------------------

The patch is for master branch? There we already use ThreadFactoryBuilder which will add its own counter if passed a name format.  So all looks fine there.  In branch-2 even what u said in description is valid.
{code}
this.longCompactions = new ThreadPoolExecutor(largeThreads, largeThreads, 60,
        TimeUnit.SECONDS, stealJobQueue,
        new ThreadFactory() {
          @Override
          public Thread newThread(Runnable r) {
            String name = n + "-longCompactions-" + System.currentTimeMillis();
            return new Thread(r, name);
          }
        });
{code}
Dont know which jira changed it in master.  We need to fix in branch(s) with what is there in master branch right now.

> Set unique name to longCompactions/shortCompactions threads
> -----------------------------------------------------------
>
>                 Key: HBASE-22930
>                 URL: https://issues.apache.org/jira/browse/HBASE-22930
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Minor
>
> Sometime observed multiple compaction threads have the same name which is misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)