You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by Andy Seaborne <an...@apache.org> on 2012/05/21 13:06:03 UTC

Rename: graph.query.Query -> graph.query.GQuery?

We have two classes called Query and they are not related.

com.hp.hpl.jena.query.Query
    (in ARQ, part of the API)
com.hp.hpl.jena.graph.query.Query
    (in Jena, not API but is SPI,
     suited to RDQL but not SPARQL)

Proposal: rename ....graph.query.Query as "GQuery".

	Andy

Re: Renaming

Posted by Andy Seaborne <an...@apache.org>.
graph.Query -> graph.GraphQuery
and
remove vocabulary.ResultSet done.

Shout if you find any problems.

	Andy

On 24/05/12 17:12, Andy Seaborne wrote:
> On 24/05/12 16:14, Robert Vesse wrote:
>> Another similar candidate for renaming is com.hp.hpl.jena.query.ResultSet
>> and com.hp.hpl.jena.vocabulary.ResultSet
>>
>> Just to avoid ambiguity and autocomplete issues I'd prefer the latter to
>> be called ResultSetVocab or ResultSetVocabulary
>
> Removing that one might the the right choice - it's superseded by
> ResultSetGraphVocab (the W3C namespace version of the same)
>
> I did a build of core and arq without it and didn't have any problems.
>
> Andy
>
>>
>> Rob
>>
>>
>>
>> On 5/21/12 7:42 AM, "Andy Seaborne"<an...@apache.org> wrote:
>>
>>> On 21/05/12 12:10, Damian Steer wrote:
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>> Hash: SHA1
>>>>
>>>> On 21/05/12 12:06, Andy Seaborne wrote:
>>>>> We have two classes called Query and they are not related.
>>>>>
>>>>> com.hp.hpl.jena.query.Query (in ARQ, part of the API)
>>>>> com.hp.hpl.jena.graph.query.Query (in Jena, not API but is SPI,
>>>>> suited to RDQL but not SPARQL)
>>>>>
>>>>> Proposal: rename ....graph.query.Query as "GQuery".
>>>>>
>>>>> Andy
>>>>
>>>> Suggest a more explicit name: GraphQuery.
>>>
>>> Yes - that's a better name.
>>>
>>>>
>>>> But +1 to a rename. Autocomplete catches me out occasionally.
>>>
>>> Andy
>>>
>>>>
>>>> Damian
>>>> -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG v1.4.11 (GNU/Linux)
>>>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>>>>
>>>> iEYEARECAAYFAk+6IpgACgkQAyLCB+mTtymxawCeL5TOE0dFSym4EqhAYoBHufuB
>>>> Gv4AoKsAsi6bpGIuhKFDkqR1i3vFhdgN
>>>> =QN1k
>>>> -----END PGP SIGNATURE-----
>>>
>>
>

Re: Renaming

Posted by Andy Seaborne <an...@apache.org>.
On 24/05/12 16:14, Robert Vesse wrote:
> Another similar candidate for renaming is com.hp.hpl.jena.query.ResultSet
> and com.hp.hpl.jena.vocabulary.ResultSet
>
> Just to avoid ambiguity and autocomplete issues I'd prefer the latter to
> be called ResultSetVocab or ResultSetVocabulary

Removing that one might the the right choice - it's superseded by
ResultSetGraphVocab (the W3C namespace version of the same)

I did a build of core and arq without it and didn't have any problems.

	Andy

>
> Rob
>
>
>
> On 5/21/12 7:42 AM, "Andy Seaborne"<an...@apache.org>  wrote:
>
>> On 21/05/12 12:10, Damian Steer wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> On 21/05/12 12:06, Andy Seaborne wrote:
>>>> We have two classes called Query and they are not related.
>>>>
>>>> com.hp.hpl.jena.query.Query (in ARQ, part of the API)
>>>> com.hp.hpl.jena.graph.query.Query (in Jena, not API but is SPI,
>>>> suited to RDQL but not SPARQL)
>>>>
>>>> Proposal: rename ....graph.query.Query as "GQuery".
>>>>
>>>> Andy
>>>
>>> Suggest a more explicit name: GraphQuery.
>>
>> Yes - that's a better name.
>>
>>>
>>> But +1 to a rename. Autocomplete catches me out occasionally.
>>
>> 	Andy
>>
>>>
>>> Damian
>>> -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG v1.4.11 (GNU/Linux)
>>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>>>
>>> iEYEARECAAYFAk+6IpgACgkQAyLCB+mTtymxawCeL5TOE0dFSym4EqhAYoBHufuB
>>> Gv4AoKsAsi6bpGIuhKFDkqR1i3vFhdgN
>>> =QN1k
>>> -----END PGP SIGNATURE-----
>>
>

Re: Renaming

Posted by Robert Vesse <rv...@yarcdata.com>.
Another similar candidate for renaming is com.hp.hpl.jena.query.ResultSet
and com.hp.hpl.jena.vocabulary.ResultSet

Just to avoid ambiguity and autocomplete issues I'd prefer the latter to
be called ResultSetVocab or ResultSetVocabulary

Rob



On 5/21/12 7:42 AM, "Andy Seaborne" <an...@apache.org> wrote:

>On 21/05/12 12:10, Damian Steer wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 21/05/12 12:06, Andy Seaborne wrote:
>>> We have two classes called Query and they are not related.
>>>
>>> com.hp.hpl.jena.query.Query (in ARQ, part of the API)
>>> com.hp.hpl.jena.graph.query.Query (in Jena, not API but is SPI,
>>> suited to RDQL but not SPARQL)
>>>
>>> Proposal: rename ....graph.query.Query as "GQuery".
>>>
>>> Andy
>>
>> Suggest a more explicit name: GraphQuery.
>
>Yes - that's a better name.
>
>>
>> But +1 to a rename. Autocomplete catches me out occasionally.
>
>	Andy
>
>>
>> Damian
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.11 (GNU/Linux)
>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>>
>> iEYEARECAAYFAk+6IpgACgkQAyLCB+mTtymxawCeL5TOE0dFSym4EqhAYoBHufuB
>> Gv4AoKsAsi6bpGIuhKFDkqR1i3vFhdgN
>> =QN1k
>> -----END PGP SIGNATURE-----
>

Re: Rename: graph.query.Query -> graph.query.GQuery?

Posted by Andy Seaborne <an...@apache.org>.
On 21/05/12 12:10, Damian Steer wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 21/05/12 12:06, Andy Seaborne wrote:
>> We have two classes called Query and they are not related.
>>
>> com.hp.hpl.jena.query.Query (in ARQ, part of the API)
>> com.hp.hpl.jena.graph.query.Query (in Jena, not API but is SPI,
>> suited to RDQL but not SPARQL)
>>
>> Proposal: rename ....graph.query.Query as "GQuery".
>>
>> Andy
>
> Suggest a more explicit name: GraphQuery.

Yes - that's a better name.

>
> But +1 to a rename. Autocomplete catches me out occasionally.

	Andy

>
> Damian
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk+6IpgACgkQAyLCB+mTtymxawCeL5TOE0dFSym4EqhAYoBHufuB
> Gv4AoKsAsi6bpGIuhKFDkqR1i3vFhdgN
> =QN1k
> -----END PGP SIGNATURE-----

Re: Rename: graph.query.Query -> graph.query.GQuery?

Posted by Damian Steer <d....@bristol.ac.uk>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 21/05/12 12:06, Andy Seaborne wrote:
> We have two classes called Query and they are not related.
> 
> com.hp.hpl.jena.query.Query (in ARQ, part of the API) 
> com.hp.hpl.jena.graph.query.Query (in Jena, not API but is SPI, 
> suited to RDQL but not SPARQL)
> 
> Proposal: rename ....graph.query.Query as "GQuery".
> 
> Andy

Suggest a more explicit name: GraphQuery.

But +1 to a rename. Autocomplete catches me out occasionally.

Damian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk+6IpgACgkQAyLCB+mTtymxawCeL5TOE0dFSym4EqhAYoBHufuB
Gv4AoKsAsi6bpGIuhKFDkqR1i3vFhdgN
=QN1k
-----END PGP SIGNATURE-----