[GitHub] [hive] ayushtkn commented on a diff in pull request #4158: HIVE-26655: VectorUDAFBloomFilterMerge should take care of safe batch handling when working in parallel

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #4158:
URL: https://github.com/apache/hive/pull/4158#discussion_r1149193455


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFBloomFilterMerge.java:
##########
@@ -602,4 +602,11 @@ public void assignRowColumn(VectorizedRowBatch batch, int batchIndex, int column
     Aggregation bfAgg = (Aggregation) agg;
     outputColVector.setVal(batchIndex, bfAgg.bfBytes, 0, bfAgg.bfBytes.length);
   }
+
+  /**
+   * Let's clone the batch when we're working in parallel, see HIVE-26655.
+   */
+  public boolean batchNeedsClone() {
+    return numThreads > 0;
+  }

Review Comment:
   just a quick pass, if thread count is 1, you still need a clone? for parallel execution it should be more than 1 thread? or some catch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org