You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2023/06/15 02:30:25 UTC

[GitHub] [kyuubi] turboFei commented on a diff in pull request #4965: [BEELINE] Remove comments for non python mode

turboFei commented on code in PR #4965:
URL: https://github.com/apache/kyuubi/pull/4965#discussion_r1230348989


##########
kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java:
##########
@@ -50,6 +56,13 @@ public KyuubiBeeLine(boolean isBeeLine) {
     super(isBeeLine);
     try {
       DynFields.builder().hiddenImpl(BeeLine.class, "commands").buildChecked(this).set(commands);
+
+      Field resourceBundleField = BeeLine.class.getDeclaredField("resourceBundle");
+      resourceBundleField.setAccessible(true);
+      Field modifiers = Field.class.getDeclaredField("modifiers");
+      modifiers.setAccessible(true);
+      modifiers.setInt(resourceBundleField, resourceBundleField.getModifiers() & ~Modifier.FINAL);

Review Comment:
   I do not use DynFields because now DynFields can not set final static field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org