You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/02/01 01:32:50 UTC
[GitHub] incubator-brooklyn pull request: fix bug where missing script dir ...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/499
fix bug where missing script dir causes null script dir explicitly set in ssh tool
bug introduced in #476
affects all deployments to ssh machines where script dir is not expliclty set, causing NPE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn fix-null-script-dir
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #499
----
commit 62a285c50541ce8ccb4a51c2a3e4fb31e0eca48c
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-02-01T00:30:32Z
fix bug where missing script dir causes null script dir explicitly set in ssh tool
introduced in #476
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix bug where missing script dir ...
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/499#issuecomment-72431999
Embarrassing :flushed: your fix looks good. I'll shout up if I see a problem in practice, but test coverage is good so I don't anticipate a problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix bug where missing script dir ...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/499#issuecomment-72344762
i'm going to merge this CTR because it is critical. @aledsage @richardcloudsoft would one of you cast an eye over this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix bug where missing script dir ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---