You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/03 11:44:29 UTC
[GitHub] [flink] wangyang0918 opened a new pull request #10761:
[FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
wangyang0918 opened a new pull request #10761: [FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
URL: https://github.com/apache/flink/pull/10761
Rest port(rest.bind-port), blob port(blob.server.port) and rpc port(yarn.application-master.port) could both support a list of ports (“50100,50101”), ranges" + " (“50100-50200”) or a combination of both.
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Remove the following TODO codes in `YarnEntrypointUtils`.
Rest port(rest.bind-port), blob port(blob.server.port) and rpc port(yarn.application-master.port) could both support a list of ports (“50100,50101”), ranges" + " (“50100-50200”) or a combination of both.
## Brief change log
* Remove TODO codes and unused constants
## Verifying this change
* Do not need tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #10761: [FLINK-15457][yarn]
Remove finished TODO in YarnEntrypointUtils
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10761: [FLINK-15457][yarn] Remove finished TODO in YarnEntrypointUtils
URL: https://github.com/apache/flink/pull/10761
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10761:
[FLINK-15457][yarn] Remove finished TODO in YarnEntrypointUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10761: [FLINK-15457][yarn] Remove finished TODO in YarnEntrypointUtils
URL: https://github.com/apache/flink/pull/10761#issuecomment-570553190
<!--
Meta data
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142988493 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
Hash:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4083 TriggerType:PUSH TriggerID:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832
Hash:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143012009 TriggerType:PUSH TriggerID:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832
-->
## CI report:
* 544ee0be382ed4beaa34e9c56c59efb6bc36a384 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142988493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079)
* b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143012009) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4083)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10761:
[FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10761: [FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
URL: https://github.com/apache/flink/pull/10761#issuecomment-570553190
<!--
Meta data
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142988493 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
-->
## CI report:
* 544ee0be382ed4beaa34e9c56c59efb6bc36a384 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142988493) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10761: [FLINK-15457][yarn]
Remove finished TODO and unused ConfigConstants
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10761: [FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
URL: https://github.com/apache/flink/pull/10761#issuecomment-570551190
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 544ee0be382ed4beaa34e9c56c59efb6bc36a384 (Fri Jan 03 11:47:59 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15457).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #10761: [FLINK-15457][yarn]
Remove finished TODO and unused ConfigConstants
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #10761: [FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
URL: https://github.com/apache/flink/pull/10761#issuecomment-570574905
They are part of the API and hence must be retained.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10761:
[FLINK-15457][yarn] Remove finished TODO in YarnEntrypointUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10761: [FLINK-15457][yarn] Remove finished TODO in YarnEntrypointUtils
URL: https://github.com/apache/flink/pull/10761#issuecomment-570553190
<!--
Meta data
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142988493 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
Hash:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4083 TriggerType:PUSH TriggerID:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832
Hash:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143012009 TriggerType:PUSH TriggerID:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832
-->
## CI report:
* 544ee0be382ed4beaa34e9c56c59efb6bc36a384 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142988493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079)
* b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143012009) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4083)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10761:
[FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10761: [FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
URL: https://github.com/apache/flink/pull/10761#issuecomment-570553190
<!--
Meta data
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142988493 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
-->
## CI report:
* 544ee0be382ed4beaa34e9c56c59efb6bc36a384 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142988493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10761:
[FLINK-15457][yarn] Remove finished TODO in YarnEntrypointUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10761: [FLINK-15457][yarn] Remove finished TODO in YarnEntrypointUtils
URL: https://github.com/apache/flink/pull/10761#issuecomment-570553190
<!--
Meta data
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142988493 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
Hash:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832
-->
## CI report:
* 544ee0be382ed4beaa34e9c56c59efb6bc36a384 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142988493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079)
* b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10761: [FLINK-15457][yarn]
Remove finished TODO and unused ConfigConstants
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10761: [FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
URL: https://github.com/apache/flink/pull/10761#issuecomment-570593358
Make sense to me. I have removed the `ConfigConstants` related changes.
@zentol Please take a look again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10761: [FLINK-15457][yarn]
Remove finished TODO and unused ConfigConstants
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10761: [FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
URL: https://github.com/apache/flink/pull/10761#issuecomment-570553190
<!--
Meta data
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
-->
## CI report:
* 544ee0be382ed4beaa34e9c56c59efb6bc36a384 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10761:
[FLINK-15457][yarn] Remove finished TODO in YarnEntrypointUtils
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10761: [FLINK-15457][yarn] Remove finished TODO in YarnEntrypointUtils
URL: https://github.com/apache/flink/pull/10761#issuecomment-570553190
<!--
Meta data
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
Hash:544ee0be382ed4beaa34e9c56c59efb6bc36a384 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142988493 TriggerType:PUSH TriggerID:544ee0be382ed4beaa34e9c56c59efb6bc36a384
Hash:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4083 TriggerType:PUSH TriggerID:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832
Hash:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143012009 TriggerType:PUSH TriggerID:b1fe280cb359d96df845e2eaa7ecfa1f0d03f832
-->
## CI report:
* 544ee0be382ed4beaa34e9c56c59efb6bc36a384 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142988493) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4079)
* b1fe280cb359d96df845e2eaa7ecfa1f0d03f832 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143012009) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4083)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10761: [FLINK-15457][yarn]
Remove finished TODO and unused ConfigConstants
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10761: [FLINK-15457][yarn] Remove finished TODO and unused ConfigConstants
URL: https://github.com/apache/flink/pull/10761#issuecomment-570565334
Hi @zentol Thanks for your comments.
The three config constants `DEFAULT_YARN_APPLICATION_MASTER_PORT` `YARN_APPLICATION_MASTER_PORT` `DEFAULT_YARN_JOB_MANAGER_PORT` have not been used anywhere now. And they could not take effect.
Do you think we still need to keep them there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services