You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/01/21 00:23:16 UTC
Re: Review Request 55773: Rejected optimizing if we are working with a
libcxx with UB.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55773/
-----------------------------------------------------------
(Updated Jan. 21, 2017, 1:23 a.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Turned warning into error.
Summary (updated)
-----------------
Rejected optimizing if we are working with a libcxx with UB.
Bugs: MESOS-6606
https://issues.apache.org/jira/browse/MESOS-6606
Repository: mesos
Description (updated)
-------
See summary.
Diffs (updated)
-----
3rdparty/stout/configure.ac cac14577caa9085728f89af9f7511c45ee37f78d
Diff: https://reviews.apache.org/r/55773/diff/
Testing
-------
* tested on various Linux configurations internal CI
* tested on OS X Sierra with the bundled compiler+stdlib and versions close to their respective HEADs
Thanks,
Benjamin Bannier
Re: Review Request 55773: Rejected optimizing if we are working with a
libcxx with UB.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55773/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 7:55 a.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Rebased.
Bugs: MESOS-6606
https://issues.apache.org/jira/browse/MESOS-6606
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/stout/configure.ac cac14577caa9085728f89af9f7511c45ee37f78d
Diff: https://reviews.apache.org/r/55773/diff/
Testing
-------
* tested on various Linux configurations internal CI
* tested on OS X Sierra with the bundled compiler+stdlib and versions close to their respective HEADs
Thanks,
Benjamin Bannier
Re: Review Request 55773: Rejected optimizing if we are working with a
libcxx with UB.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55773/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 8:49 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Used idiomatic way to output progress.
Bugs: MESOS-6606
https://issues.apache.org/jira/browse/MESOS-6606
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/stout/configure.ac cac14577caa9085728f89af9f7511c45ee37f78d
Diff: https://reviews.apache.org/r/55773/diff/
Testing
-------
* tested on various Linux configurations internal CI
* tested on OS X Sierra with the bundled compiler+stdlib and versions close to their respective HEADs
Thanks,
Benjamin Bannier
Re: Review Request 55773: Rejected optimizing if we are working with a
libcxx with UB.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55773/#review162544
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55771, 55772, 55773]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 21, 2017, 12:23 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55773/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2017, 12:23 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-6606
> https://issues.apache.org/jira/browse/MESOS-6606
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/stout/configure.ac cac14577caa9085728f89af9f7511c45ee37f78d
>
> Diff: https://reviews.apache.org/r/55773/diff/
>
>
> Testing
> -------
>
> * tested on various Linux configurations internal CI
> * tested on OS X Sierra with the bundled compiler+stdlib and versions close to their respective HEADs
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 55773: Rejected optimizing if we are working with a
libcxx with UB.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55773/#review162800
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Jan. 21, 2017, 12:23 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55773/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2017, 12:23 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-6606
> https://issues.apache.org/jira/browse/MESOS-6606
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/stout/configure.ac cac14577caa9085728f89af9f7511c45ee37f78d
>
> Diff: https://reviews.apache.org/r/55773/diff/
>
>
> Testing
> -------
>
> * tested on various Linux configurations internal CI
> * tested on OS X Sierra with the bundled compiler+stdlib and versions close to their respective HEADs
>
>
> Thanks,
>
> Benjamin Bannier
>
>