You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alex Petrov (JIRA)" <ji...@apache.org> on 2018/09/18 10:45:00 UTC
[jira] [Commented] (CASSANDRA-14755) Reinstate repaired data
tracking when ReadRepair == NONE
[ https://issues.apache.org/jira/browse/CASSANDRA-14755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618908#comment-16618908 ]
Alex Petrov commented on CASSANDRA-14755:
-----------------------------------------
[~beobal] sorry: I was looking closely at all the {{on*}} methods to ensure they do not have any effects, but overlooked the {{close}}. Thank you for fixing it.
+1, LGTM!
> Reinstate repaired data tracking when ReadRepair == NONE
> --------------------------------------------------------
>
> Key: CASSANDRA-14755
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14755
> Project: Cassandra
> Issue Type: Bug
> Components: Local Write-Read Paths
> Reporter: Sam Tunnicliffe
> Assignee: Sam Tunnicliffe
> Priority: Major
> Fix For: 4.0
>
>
> Some of the refactoring in CASSANDRA-14698 breaks repaired data tracking when read repair is disabled as it skips wrapping the {{MergeIterator}} in {{DataResolver::wrapMergeListener}}. If repaired tracking is enabled, the iterator still needs to be extended so that it calls {{RepairedDataTracker::verify}} on close. This wasn't easy to spot as the new dtests for CASSANDRA-14145 haven't yet been merged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org