[jira] [Commented] (GEODE-5739) Server and LocatorStarter Rules should use respective Launchers

["Jinmei Liao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652002#comment-16652002 ] 

Jinmei Liao commented on GEODE-5739:
------------------------------------

-1 on this: When I first started these rules, I want the rule to use the api as close to the core as possible, so that we don't end up testing the launcher as well. We use the rules to test the functionality the developer is interested in, do not want to get launcher code (which seemed very messy at that time, probably still still is) in the way.

> Server and LocatorStarter Rules should use respective Launchers
> ---------------------------------------------------------------
>
>                 Key: GEODE-5739
>                 URL: https://issues.apache.org/jira/browse/GEODE-5739
>             Project: Geode
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Jason Huynh
>            Assignee: Juan José Ramos Cassella
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> In a review, it was mentioned from that we can change ServerStarterRule and LocatorStarterRule to use ServerLauncher and LocatorLauncher.
> This way the rules are using the User API directly. The Launchers are in-process APIs so they don't launch/fork new JVMs, they simply launch a Server or a Locator. The APIs also include stopping and this stopMember() method could then simply invoke serverLauncher.stop().
> PS: The forking of Server/Locator JVMs is performed by GFSH, not by these Launcher classes.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)