You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/04/01 11:18:51 UTC
[GitHub] [ozone] bharatviswa504 opened a new pull request #2107: HDDS-5058. Make getScmInfo retry for a duration.
bharatviswa504 opened a new pull request #2107:
URL: https://github.com/apache/ozone/pull/2107
## What changes were proposed in this pull request?
This Jira proposes to add a ceration duration to try getScmInfo, instead of retry forever with fixed sleep.
In a few docker tests CI run, we have seen this issue, after 15 retries Om init failed, as SCM is started later.
## What is the link to the Apache JIRA
https://github.com/apache/ozone/pull/2100
## How was this patch tested?
Manually tested with docker compose env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2107: HDDS-5058. Make getScmInfo retry for a duration.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2107:
URL: https://github.com/apache/ozone/pull/2107#discussion_r606032533
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -510,6 +510,11 @@
"hdds.scm.ha.security.enable";
public static final boolean OZONE_SCM_HA_SECURITY_SUPPORTED_DEFAULT = false;
+ public static final String OZONE_SCM_INFO_WAIT_DURATION = "ozone.scm.info" +
Review comment:
I will take care of this during commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 edited a comment on pull request #2107: HDDS-5058. Make getScmInfo retry for a duration.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 edited a comment on pull request #2107:
URL: https://github.com/apache/ozone/pull/2107#issuecomment-812273212
I will commit this shortly, as this will help in fixing occasional failures in docker tests.
Example run:
https://github.com/apache/ozone/runs/2243496103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2107: HDDS-5058. Make getScmInfo retry for a duration.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2107:
URL: https://github.com/apache/ozone/pull/2107#issuecomment-812273212
I will commit this shortly, as this will help in fixing occasional failures in docker tests.
One such run:
https://github.com/apache/ozone/runs/2243496103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2107: HDDS-5058. Make getScmInfo retry for a duration.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2107:
URL: https://github.com/apache/ozone/pull/2107#issuecomment-812274915
Thank You @bshashikant and @GlenGeng for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on a change in pull request #2107: HDDS-5058. Make getScmInfo retry for a duration.
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on a change in pull request #2107:
URL: https://github.com/apache/ozone/pull/2107#discussion_r605628196
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -510,6 +510,11 @@
"hdds.scm.ha.security.enable";
public static final boolean OZONE_SCM_HA_SECURITY_SUPPORTED_DEFAULT = false;
+ public static final String OZONE_SCM_INFO_WAIT_DURATION = "ozone.scm.info" +
Review comment:
```
public static final String OZONE_SCM_INFO_WAIT_DURATION =
"ozone.scm.info.wait.duration";
```
So that one can easily search the key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 closed pull request #2107: HDDS-5058. Make getScmInfo retry for a duration.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 closed pull request #2107:
URL: https://github.com/apache/ozone/pull/2107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org