[GitHub] [tvm-rfcs] areusch commented on pull request #46: Module Based Model Runtime for AOT

[GitBox <gi...@apache.org>]

areusch commented on pull request #46:
URL: https://github.com/apache/tvm-rfcs/pull/46#issuecomment-992762313


   @manupa-arm thanks! I think ultimately the @ashutosh-arm pass could be a good way to implement ConstLoader, but for now I'm hoping we can simply rename. In the long run, I'd actually like to be able to do a similar thing with MetadataModule--define a special data type in Relay which holds this Metadata, and "link" tvm_struct_get calls against it just before codegen with an IRModule -> IRModule pass to replace such tvm_struct_get with the value from Metadata. 
   
   I'm not sure what the best approach is here, probably need to collect some feedback from the community/users. However, at some level it all seems like metadata to me (constants could be params tho, and it may be desirable to be able to swap those params after compilation).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org