You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/16 18:54:46 UTC
[GitHub] [tvm] sunggg opened a new pull request #9757: [MetaScheduler] Misc improvement of the Measurer
sunggg opened a new pull request #9757:
URL: https://github.com/apache/tvm/pull/9757
Nice to meet you all.
This PR contains several changes in meta_scheudle runner and builder.
Please review this and feel free to give any feedback.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sunggg commented on pull request #9757: [MetaSchedule] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
sunggg commented on pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#issuecomment-996402319
>
Aren't there three files in total?
My new commit contains changes in three files you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sunggg edited a comment on pull request #9757: [MetaSchedule] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
sunggg edited a comment on pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#issuecomment-996402319
> https://github.com/apache/tvm/pull/9757#issuecomment-996337676
Aren't there three files in total?
My new commit contains changes in three files you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9757: [MetaSchedule] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#discussion_r771103108
##########
File path: python/tvm/meta_schedule/builder/local_builder.py
##########
@@ -15,20 +15,36 @@
# specific language governing permissions and limitations
# under the License.
"""Local builder that compile on the local host"""
+import logging
import os
import tempfile
-from typing import Callable, List, Optional, Union
+from typing import Callable, Dict, List, Optional, Union
from tvm._ffi import register_func
from tvm.ir import IRModule
-from tvm.runtime import Module
+from tvm.runtime import Module, NDArray, load_param_dict, save_param_dict
from tvm.target import Target
from ...contrib.popen_pool import MapResult, PopenPoolExecutor, StatusKind
from ..utils import cpu_count, get_global_func_with_default_on_worker
from .builder import BuilderInput, BuilderResult, PyBuilder
+logger = logging.getLogger(__name__)
Review comment:
Thanks! just click “resolve conversation” yourself if the comment is addressed :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9757: [MetaSchedule] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#issuecomment-996436735
Oh I’m sorry that I misread! The linter error this time is that we forgot to add docs for “params” in c++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sunggg edited a comment on pull request #9757: [MetaSchedule] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
sunggg edited a comment on pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#issuecomment-996402319
@junrushao1994, Aren't there three files in total?
My new commit contains changes in three files you mentioned.
I'm now seeing this message.
```
Some checks were not successful
2 successful and 1 errored checks
```
Since I'm new to this system, any advice would be greatly appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sunggg commented on a change in pull request #9757: [MetaScheduler] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
sunggg commented on a change in pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#discussion_r770982840
##########
File path: python/tvm/meta_schedule/builder/local_builder.py
##########
@@ -15,20 +15,36 @@
# specific language governing permissions and limitations
# under the License.
"""Local builder that compile on the local host"""
+import logging
import os
import tempfile
-from typing import Callable, List, Optional, Union
+from typing import Callable, Dict, List, Optional, Union
from tvm._ffi import register_func
from tvm.ir import IRModule
-from tvm.runtime import Module
+from tvm.runtime import Module, NDArray, load_param_dict, save_param_dict
from tvm.target import Target
from ...contrib.popen_pool import MapResult, PopenPoolExecutor, StatusKind
from ..utils import cpu_count, get_global_func_with_default_on_worker
from .builder import BuilderInput, BuilderResult, PyBuilder
+logger = logging.getLogger(__name__)
Review comment:
Thank you for the feedback! I've just pushed the updated commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sunggg edited a comment on pull request #9757: [MetaSchedule] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
sunggg edited a comment on pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#issuecomment-996402319
@junrushao1994, Aren't there three files in total?
My new commit contains changes in three files you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9757: [MetaScheduler] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#issuecomment-996110622
CC: @Hzfengsy @yidawang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9757: [MetaSchedule] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#issuecomment-996337676
Hey you forgot the fix the two "ditto"s :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9757: [MetaSchedule] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#issuecomment-997013528
CC @zxybazh for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9757: [MetaSchedule] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9757:
URL: https://github.com/apache/tvm/pull/9757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9757: [MetaScheduler] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#discussion_r770850153
##########
File path: python/tvm/meta_schedule/runner/local_runner.py
##########
@@ -25,12 +27,14 @@
from .config import EvaluatorConfig
from .runner import PyRunner, RunnerFuture, RunnerInput, RunnerResult
from .utils import (
- T_ARG_INFO_JSON_OBJ_LIST,
T_ARGUMENT_LIST,
+ T_ARG_INFO_JSON_OBJ_LIST,
alloc_argument_common,
run_evaluator_common,
)
+logger = logging.getLogger(__name__)
Review comment:
ditto
##########
File path: python/tvm/meta_schedule/builder/local_builder.py
##########
@@ -15,20 +15,36 @@
# specific language governing permissions and limitations
# under the License.
"""Local builder that compile on the local host"""
+import logging
import os
import tempfile
-from typing import Callable, List, Optional, Union
+from typing import Callable, Dict, List, Optional, Union
from tvm._ffi import register_func
from tvm.ir import IRModule
-from tvm.runtime import Module
+from tvm.runtime import Module, NDArray, load_param_dict, save_param_dict
from tvm.target import Target
from ...contrib.popen_pool import MapResult, PopenPoolExecutor, StatusKind
from ..utils import cpu_count, get_global_func_with_default_on_worker
from .builder import BuilderInput, BuilderResult, PyBuilder
+logger = logging.getLogger(__name__)
Review comment:
Likely we will need to append `# pylint: disable=invalid-name` to this line to suppress the linter
##########
File path: python/tvm/meta_schedule/runner/rpc_runner.py
##########
@@ -31,13 +32,16 @@
from .config import EvaluatorConfig, RPCConfig
from .runner import PyRunner, RunnerFuture, RunnerInput, RunnerResult
from .utils import (
- T_ARG_INFO_JSON_OBJ_LIST,
T_ARGUMENT_LIST,
+ T_ARG_INFO_JSON_OBJ_LIST,
alloc_argument_common,
run_evaluator_common,
)
+logger = logging.getLogger(__name__)
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sunggg edited a comment on pull request #9757: [MetaSchedule] Misc improvement of the Measurer
Posted by GitBox <gi...@apache.org>.
sunggg edited a comment on pull request #9757:
URL: https://github.com/apache/tvm/pull/9757#issuecomment-996402319
https://github.com/apache/tvm/pull/9757#issuecomment-996337676
Aren't there three files in total?
My new commit contains changes in three files you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org