[GitHub] [spark] shuwang21 commented on pull request #41225: [SPARK-43583][CORE] get MergedBlockedMetaReqHandler from the delegate instead of the SaslRpcHandler instance

["shuwang21 (via GitHub)" <gi...@apache.org>]

shuwang21 commented on PR #41225:
URL: https://github.com/apache/spark/pull/41225#issuecomment-1554049148

   LGTM. Thanks for your efforts!
   
   Do you think when `spark.network.crypto.saslFallback=true` and L95 from `AuthRpcHandler.java`. 
   ```
   saslHandler = new SaslRpcHandler(conf, channel, null, secretKeyHolder);
   ```
   which will set `delegate=null`. Will this cause potential NPE? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org