You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "je-ik (via GitHub)" <gi...@apache.org> on 2023/06/20 14:32:05 UTC
[GitHub] [beam] je-ik opened a new pull request, #27176: [runners-flink] #27175 fix coder for eagerly bound state
je-ik opened a new pull request, #27176:
URL: https://github.com/apache/beam/pull/27176
Closes #27175
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #27176: [runners-flink] #27175 fix coder for eagerly bound state
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #27176:
URL: https://github.com/apache/beam/pull/27176#discussion_r1235407819
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkStateInternals.java:
##########
@@ -1612,7 +1611,7 @@ public <T> SetState<T> bindSet(String id, StateSpec<SetState<T>> spec, Coder<T>
new MapStateDescriptor<>(
id,
new CoderTypeSerializer<>(elemCoder, pipelineOptions),
- VoidSerializer.INSTANCE));
+ new BooleanSerializer()));
Review Comment:
use BooleanSerializer.INSTANCE ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on a diff in pull request #27176: [runners-flink] #27175 fix coder for eagerly bound state
Posted by "je-ik (via GitHub)" <gi...@apache.org>.
je-ik commented on code in PR #27176:
URL: https://github.com/apache/beam/pull/27176#discussion_r1236494513
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkStateInternals.java:
##########
@@ -1612,7 +1611,7 @@ public <T> SetState<T> bindSet(String id, StateSpec<SetState<T>> spec, Coder<T>
new MapStateDescriptor<>(
id,
new CoderTypeSerializer<>(elemCoder, pipelineOptions),
- VoidSerializer.INSTANCE));
+ new BooleanSerializer()));
Review Comment:
+1
changed that in both cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27176: [runners-flink] #27175 fix coder for eagerly bound state
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27176:
URL: https://github.com/apache/beam/pull/27176#issuecomment-1598913919
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] je-ik commented on pull request #27176: [runners-flink] #27175 fix coder for eagerly bound state
Posted by "je-ik (via GitHub)" <gi...@apache.org>.
je-ik commented on PR #27176:
URL: https://github.com/apache/beam/pull/27176#issuecomment-1598911815
R: @dmvk @JozoVilcek
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #27176: [runners-flink] #27175 fix coder for eagerly bound state
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #27176:
URL: https://github.com/apache/beam/pull/27176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org