You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/05/14 06:00:13 UTC

[GitHub] [ignite] ivandasch commented on a change in pull request #7751: IGNITE-10100 Implement calling .NET service from java

ivandasch commented on a change in pull request #7751:
URL: https://github.com/apache/ignite/pull/7751#discussion_r424888046



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/service/GridServiceProxy.java
##########
@@ -63,6 +69,22 @@
     /** */
     private static final long serialVersionUID = 0L;
 
+    /** */
+    private static final Method PLATFORM_SERVICE_INVOKE_METHOD;
+
+    static {
+        Method mtd;
+
+        try {
+            mtd = PlatformService.class.getMethod("invokeMethod", String.class, boolean.class, Object[].class);
+        }
+        catch (NoSuchMethodException e) {

Review comment:
       Unfortunatelly, we cannot remove this catch, because `NoSuchMethodException` this is checked one. You suggests to fail node? To be honest, I don't think that failing node in static initializer is a good variant. Let's explain. Let's imagine situatuin, that someone mistakenly delete `invokeMethod` from code, but then he or she get failing tests and easily correct this mistake. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org