You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/09/24 19:28:50 UTC

[GitHub] [hudi] yihua commented on a diff in pull request #7968: [DOCS] Update hive metastore sync docs

yihua commented on code in PR #7968:
URL: https://github.com/apache/hudi/pull/7968#discussion_r1335234080


##########
website/docs/syncing_metastore.md:
##########
@@ -33,17 +40,16 @@ Among them, following are the required arguments:
 ```
 Corresponding datasource options for the most commonly used hive sync configs are as follows:
 
-| HiveSyncConfig | DataSourceWriteOption | Description |
-| -----------   | ----------- | ----------- |
-| --database       | hoodie.datasource.hive_sync.database       | name of the target database in Hive       |
-| --table   | hoodie.datasource.hive_sync.table        | name of the target table in Hive        |
-| --user   | hoodie.datasource.hive_sync.username        | username for hive metastore        | 
-| --pass   | hoodie.datasource.hive_sync.password        | password for hive metastore        | 
-| --use-jdbc   | hoodie.datasource.hive_sync.use_jdbc        | use JDBC to connect to metastore        | 
-| --jdbc-url   | hoodie.datasource.hive_sync.jdbcurl        | Hive metastore url        |
-| --sync-mode   | hoodie.datasource.hive_sync.mode        | Mode to choose for Hive ops. Valid values are hms, jdbc and hiveql.        |
-| --partitioned-by   | hoodie.datasource.hive_sync.partition_fields        | Comma-separated column names in the table to use for determining hive partition.        |
-| --partition-value-extractor   | hoodie.datasource.hive_sync.partition_extractor_class        | Class which implements PartitionValueExtractor to extract the partition values. `SlashEncodedDayPartitionValueExtractor` by default.        |
+| HiveSyncConfig | DataSourceWriteOption | Default Value | Description |
+| -----------   | ----------- | ----------- | ----------- |
+| --database       | hoodie.datasource.hive_sync.database  |  default   | Name of the target database in Hive       |
+| --table   | hoodie.datasource.hive_sync.table |       | Name of the target table in Hive. Inferred from the table name in Hudi table config if not specified.        |

Review Comment:
   nit: add `(N/A)` to the `Default Value` column for the configs without a default value.



##########
website/docs/syncing_metastore.md:
##########
@@ -33,17 +40,16 @@ Among them, following are the required arguments:
 ```
 Corresponding datasource options for the most commonly used hive sync configs are as follows:
 
-| HiveSyncConfig | DataSourceWriteOption | Description |
-| -----------   | ----------- | ----------- |
-| --database       | hoodie.datasource.hive_sync.database       | name of the target database in Hive       |
-| --table   | hoodie.datasource.hive_sync.table        | name of the target table in Hive        |
-| --user   | hoodie.datasource.hive_sync.username        | username for hive metastore        | 
-| --pass   | hoodie.datasource.hive_sync.password        | password for hive metastore        | 
-| --use-jdbc   | hoodie.datasource.hive_sync.use_jdbc        | use JDBC to connect to metastore        | 
-| --jdbc-url   | hoodie.datasource.hive_sync.jdbcurl        | Hive metastore url        |
-| --sync-mode   | hoodie.datasource.hive_sync.mode        | Mode to choose for Hive ops. Valid values are hms, jdbc and hiveql.        |
-| --partitioned-by   | hoodie.datasource.hive_sync.partition_fields        | Comma-separated column names in the table to use for determining hive partition.        |
-| --partition-value-extractor   | hoodie.datasource.hive_sync.partition_extractor_class        | Class which implements PartitionValueExtractor to extract the partition values. `SlashEncodedDayPartitionValueExtractor` by default.        |
+| HiveSyncConfig | DataSourceWriteOption | Default Value | Description |
+| -----------   | ----------- | ----------- | ----------- |
+| --database       | hoodie.datasource.hive_sync.database  |  default   | Name of the target database in Hive       |
+| --table   | hoodie.datasource.hive_sync.table |       | Name of the target table in Hive. Inferred from the table name in Hudi table config if not specified.        |
+| --user   | hoodie.datasource.hive_sync.username |   hive     | Username for hive metastore        | 
+| --pass   | hoodie.datasource.hive_sync.password  |  hive    | Password for hive metastore        | 
+| --jdbc-url   | hoodie.datasource.hive_sync.jdbcurl  |  jdbc:hive2://localhost:10000    | Hive server url if using `jdbc` mode to sync     |
+| --sync-mode   | hoodie.datasource.hive_sync.mode    |    | Mode to choose for Hive ops. Valid values are `hms`, `jdbc` and `hiveql`. More details in the following section.       |
+| --partitioned-by   | hoodie.datasource.hive_sync.partition_fields   |     | Comma-separated column names in the table to use for determining hive partition.        |
+| --partition-value-extractor   | hoodie.datasource.hive_sync.partition_extractor_class   |  MultiPartKeysValueExtractor   | Class which implements PartitionValueExtractor to extract the partition values. Inferred automatically depending on the partition fields specified.        |

Review Comment:
   ```suggestion
   | --partition-value-extractor   | hoodie.datasource.hive_sync.partition_extractor_class   |  `org.apache.hudi.hive.MultiPartKeysValueExtractor`   | Class which implements `PartitionValueExtractor` to extract the partition values. Inferred automatically depending on the partition fields specified.        |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org