[GitHub] nifi-minifi-cpp pull request #139: MINIFI-388 Backport the rest of EVP_Diges...

[calebj <gi...@git.apache.org>]

GitHub user calebj opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/139

    MINIFI-388 Backport the rest of EVP_Digest for civetweb

    As per the discussion in apache/nifi-minifi-cpp#131. This is a backport of the `#define` declaration of `EVP_Digest()` and the matching entry in `crypto_sw` from civetweb/civetweb@fb9ef36.
    
    Without this patch, minifi fails to build on Ubuntu 14.04 with GCC 4.8.4, against OpenSSL version is 1.0.1f-1ubuntu2.22, with:
    ```
    [ 45%] Building C object thirdparty/civetweb-1.9.1/src/CMakeFiles/c-library.dir/civetweb.c.o
    /home/ubuntu/workspace/thirdparty/civetweb-1.9.1/src/civetweb.c: In function ‘ssl_get_client_cert_info’:
    /home/ubuntu/workspace/thirdparty/civetweb-1.9.1/src/civetweb.c:11873:4: error: implicit declaration of function ‘EVP_Digest’ [-Wimplicit-function-declaration]
        if (!EVP_Digest(
        ^
    make[2]: *** [thirdparty/civetweb-1.9.1/src/CMakeFiles/c-library.dir/civetweb.c.o] Error 1
    ```
    
    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NiFiLocal/nifi-minifi-cpp civet_evp_digest_backport

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #139
    
----
commit 66dc8f039ca0fa1af362c11a5bcc43475456bc74
Author: Caleb Johnson <me...@calebj.io>
Date:   2017-09-28T11:25:18Z

    MINIFI-388 Backport the rest of EVP_Digest for civetweb

----


---

[GitHub] nifi-minifi-cpp pull request #139: MINIFI-388 Backport the rest of EVP_Diges...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/139


---