[jira] Resolved: (TUSCANY-1146) ServiceContract clone() doesn't clone operations

["Raymond Feng (JIRA)" <tu...@ws.apache.org>]

     [ https://issues.apache.org/jira/browse/TUSCANY-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raymond Feng resolved TUSCANY-1146.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: Java-SCA-M3

Thanks for the patch.

I have applied to both trunk and sca-java-integration branch.

http://svn.apache.org/viewvc?view=rev&rev=512871
http://svn.apache.org/viewvc?view=rev&rev=512883



> ServiceContract clone() doesn't clone operations
> ------------------------------------------------
>
>                 Key: TUSCANY-1146
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1146
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Core
>    Affects Versions: Java-M2
>            Reporter: Scott Kurz
>         Assigned To: Raymond Feng
>             Fix For: Java-SCA-M3, Java-SCA-integration
>
>         Attachments: 1146.patch, 1146.patch
>
>
> ServiceContract.clone()  does:
>         if (operations != null) {
>             Map<String, Operation<T>> clonedOperations = new HashMap<String, Operation<T>>();
>             for (Operation<T> o : operations.values()) {
>                 clonedOperations.put(o.getName(), o);
>             }
>             copy.setOperations(clonedOperations);
>         }
> This is going to interfere with the 'operations' of the original ServiceContract (since setOperations points the Operations to the new SC).   We should have cloned the operations I believe.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org