[GitHub] HyukjinKwon commented on issue #23759: [SPARK-26840][SQL] Avoid cost-based join reorder in presence of join hints

[GitBox <gi...@apache.org>]

HyukjinKwon commented on issue #23759: [SPARK-26840][SQL] Avoid cost-based join reorder in presence of join hints
URL: https://github.com/apache/spark/pull/23759#issuecomment-463203800
 
 
   BTW, it's important to cooperate and to make other people to understand during review process for the best to the author and reviewers in my experience. A patch can be technically reviewed closely and double checked. FWIW, I also had a doubt about the reverted PR although I didn't express my concern there (at the PR you pointed out in the description).
   
   I think I asked to fill the empty JIRA description as well. It is also important to make PR more readable, title, and description. Like .. as an extreme case, let's say there's someone only who understands a logic in an open source project. No one can touch the codes later if that person somehow happens to leave the community (that's an open source :D anyone can join and leave when they want).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org