You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/08 11:34:34 UTC
[GitHub] [pulsar-test-infra] lhotari opened a new pull request #16: Set 'changed_only' to 'no' if commits cannot be found in diff-only action
lhotari opened a new pull request #16:
URL: https://github.com/apache/pulsar-test-infra/pull/16
Fixes #12 https://github.com/apache/pulsar/issues/9526
The current solution causes the build to skip tests in Pulsar builds when the pull request commits cannot be found. It's better that diff-only script sets 'changed_only' to 'no' when it's not able to determine the correct result.
The commit for a PR won't be found when shallow clones are used and there are more commits in the PR than the depth of the shallow clone. The Pulsar GitHub Action workflows use shallow clone with the depth of 25 commits. This PR will support such PRs by defaulting to `changed_only` to `no` when the commit cannot be found.
This PR also fixes support for non-PR events such as `push` event. `changed_only` is set to `no` when the triggering event isn't a `pull_request` event.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] jiazhai merged pull request #16: Set 'changed_only' to 'no' if commits cannot be found in diff-only action
Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #16:
URL: https://github.com/apache/pulsar-test-infra/pull/16
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] lhotari commented on pull request #16: Set 'changed_only' to 'no' if commits cannot be found in diff-only action
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #16:
URL: https://github.com/apache/pulsar-test-infra/pull/16#issuecomment-775219893
Another improvement in using `diff-only` would be to switch from using
```
if: steps.docs.outputs.changed_only == 'no'
```
to
```
if: steps.docs.outputs.changed_only != 'yes'
```
since this would be safe for failures in checking for changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org