[jira] Commented: (AXIS2-3296) When I am creating a AxisFault by giving a SoapFault, the SoapFaultCode is ignored.

["Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AXIS2-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542090 ] 

Amila Chinthaka Suriarachchi commented on AXIS2-3296:
-----------------------------------------------------

hi my guess is it is better to do it in this way

i.e adding null check to test whether the soapFaultCode is available or not.

if (faultCode == null) {
            if (context.isSOAP11() && (soapFaultCode != null) && (!soapFaultCode.equals(""))) {
                fault.getCode().setText(soapFaultCode);
            } else {
                fault.getCode().getValue().setText(soapFaultCode);
            }
        }

I think the problem you try to overcome is that setting null value if the value is already set with
the axisFault.getFaultCodeElement()

but here we have to change it if there is an valid soapFaultCode.


> When I am creating a AxisFault by giving a SoapFault, the SoapFaultCode is ignored.
> -----------------------------------------------------------------------------------
>
>                 Key: AXIS2-3296
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3296
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.3, nightly
>         Environment: Windows XP / JDK 1.4 (but also Sun Machine with WebSphere 5.1 and JDK 1.4)
>            Reporter: Vincent Brabant
>            Assignee: Amila Chinthaka Suriarachchi
>
> I have a SoapFault where the SoapFaultCode is soapenv:Client.
> I am throwing an AxisFault by giving the SoapFault as argument
>           throw new AxisFaul(soapFault)
> But it return always a soapenv:Receiver (SOAP1.2) or a soapenv:Server (SOAP1.1).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org