bug 31906?

[Avik Sengupta <av...@itellix.com>]

Any thoughts on http://issues.apache.org/bugzilla/show_bug.cgi?id=31906
(Pull method for continue records)

Looks good to me, but I'm not sure i've thought of all consequences. 

Can someone profile it for memory/speed?

Regards
-
Avik



---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

Re: bug 31906?

[an...@superlinksoftware.com]

I didn't look closely...are there sufficient unit tests?  In my mind as 
long as there are...tag files it touches in head, commit, revert if its 
a problem.  One simple test is that unit tests that did speed output 
would be revealing.

If it came from someone outside the normal group of contributors I'd be 
a bit more aprehensive about it (continue has always been a problem 
because there are so many "buts" and "rules" about it).

Also will need to test that it doesn't break images...  Glen is about to 
commit that stuff (as soon as I find him)

-andy

Avik Sengupta wrote:
> Any thoughts on http://issues.apache.org/bugzilla/show_bug.cgi?id=31906
> (Pull method for continue records)
> 
> Looks good to me, but I'm not sure i've thought of all consequences. 
> 
> Can someone profile it for memory/speed?
> 
> Regards
> -
> Avik
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
> The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/