You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/20 20:51:02 UTC
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1490: feat: support yaml to config plugin in plugin config page
liuxiran opened a new pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
Part of #1039
___
### New feature or improvement
- Describe the details and related test reports.
1
2
Notice: all above are just transforms in FE, it would not disturb the interface data transfer
___
### Please add the corresponding test cases if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=h1) Report
> Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=desc) (ae4bb28) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2de2c72cfa8899e98045c3059d281b90cf544404?el=desc) (2de2c72) will **decrease** coverage by `0.99%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
- Coverage 70.11% 69.12% -1.00%
==========================================
Files 130 49 -81
Lines 5340 3164 -2176
Branches 549 0 -549
==========================================
- Hits 3744 2187 -1557
+ Misses 1348 729 -619
Partials 248 248
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `55.68% <ø> (+0.12%)` | :arrow_up: |
| backend-e2e-test-ginkgo | `39.47% <ø> (ø)` | |
| backend-unit-test | `51.68% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [web/src/pages/Route/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL2luZGV4LnRzeA==) | | |
| [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | | |
| [web/src/pages/SSL/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvQ3JlYXRlLnRzeA==) | | |
| [web/src/pages/User/Logout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ291dC50c3g=) | | |
| [web/src/pages/Consumer/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1ByZXZpZXcudHN4) | | |
| [.../src/pages/Route/components/Step1/LabelsDrawer.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL0xhYmVsc0RyYXdlci50c3g=) | | |
| [web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==) | | |
| [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | | |
| [web/src/pages/Plugin/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW4vc2VydmljZS50cw==) | | |
| [...es/Route/components/DebugViews/DebugParamsView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdQYXJhbXNWaWV3LnRzeA==) | | |
| ... and [70 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=footer). Last update [2de2c72...ae4bb28](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=h1) Report
> Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=desc) (7d7af37) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **decrease** coverage by `19.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1490 +/- ##
===========================================
- Coverage 70.86% 51.68% -19.19%
===========================================
Files 135 40 -95
Lines 5485 2707 -2778
Branches 583 0 -583
===========================================
- Hits 3887 1399 -2488
+ Misses 1350 1127 -223
+ Partials 248 181 -67
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `51.68% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
| [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [114 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=footer). Last update [938b2b9...7d7af37](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#discussion_r580727300
##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -92,6 +93,11 @@ const PluginDetail: React.FC<Props> = ({
const ref = useRef<any>(null);
const data = initialData[name] || {};
const pluginType = pluginList.find((item) => item.name === name)?.type;
+ const [codeMirrorMode, setCodeMirrorMode] = useState<PluginComponent.CodeMirrorMode>('javascript');
+ const modeOptions = [
+ { label: 'Json', value: 'javascript' },
Review comment:
why use `javascript ` here? 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=h1) Report
> Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=desc) (f57a2bc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `45.75%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1490 +/- ##
===========================================
- Coverage 68.43% 22.67% -45.76%
===========================================
Files 48 48
Lines 3038 3038
===========================================
- Hits 2079 689 -1390
- Misses 720 2207 +1487
+ Partials 239 142 -97
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: |
| [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `8.91% <0.00%> (-72.28%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `21.27% <0.00%> (-70.22%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.56% <0.00%> (-68.23%)` | :arrow_down: |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `7.14% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=footer). Last update [65f792a...f57a2bc](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-791029918
> Front-end e2e test required.
got it, I`ll add it soon, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#discussion_r581448707
##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -92,6 +93,11 @@ const PluginDetail: React.FC<Props> = ({
const ref = useRef<any>(null);
const data = initialData[name] || {};
const pluginType = pluginList.find((item) => item.name === name)?.type;
+ const [codeMirrorMode, setCodeMirrorMode] = useState<PluginComponent.CodeMirrorMode>('javascript');
+ const modeOptions = [
+ { label: 'Json', value: 'javascript' },
Review comment:
> why use `javascript ` here? 🤔
thanks already changed to `json`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=h1) Report
> Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=desc) (ae4bb28) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2de2c72cfa8899e98045c3059d281b90cf544404?el=desc) (2de2c72) will **decrease** coverage by `14.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1490 +/- ##
===========================================
- Coverage 70.11% 55.68% -14.43%
===========================================
Files 130 49 -81
Lines 5340 3164 -2176
Branches 549 0 -549
===========================================
- Hits 3744 1762 -1982
+ Misses 1348 1098 -250
- Partials 248 304 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `55.68% <ø> (+0.12%)` | :arrow_up: |
| backend-e2e-test-ginkgo | `39.47% <ø> (ø)` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `57.44% <0.00%> (-34.05%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `38.46% <0.00%> (-30.77%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
| ... and [95 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=footer). Last update [2de2c72...ae4bb28](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=h1) Report
> Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=desc) (b5d5edc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **increase** coverage by `0.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
+ Coverage 68.43% 68.95% +0.52%
==========================================
Files 48 48
Lines 3038 3038
==========================================
+ Hits 2079 2095 +16
+ Misses 720 705 -15
+ Partials 239 238 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (+1.20%)` | :arrow_up: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `74.48% <0.00%> (+4.08%)` | :arrow_up: |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `50.90% <0.00%> (+9.09%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=footer). Last update [65f792a...b5d5edc](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=h1) Report
> Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=desc) (f57a2bc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `12.96%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1490 +/- ##
===========================================
- Coverage 68.43% 55.46% -12.97%
===========================================
Files 48 48
Lines 3038 3038
===========================================
- Hits 2079 1685 -394
- Misses 720 1072 +352
- Partials 239 281 +42
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `54.25% <0.00%> (-37.24%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `34.69% <0.00%> (-34.19%)` | :arrow_down: |
| [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `60.24% <0.00%> (-26.51%)` | :arrow_down: |
| [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=footer). Last update [65f792a...f57a2bc](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#discussion_r581429443
##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -243,6 +268,7 @@ const PluginDetail: React.FC<Props> = ({
</Form>
<Divider orientation="left">Data Editor</Divider>
<PageHeader
+ className="test"
Review comment:
> Is the style sheet here added correctly?
good catch, this style sheet is useless, fixed, thanks a lot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=h1) Report
> Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=desc) (b5d5edc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `8.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
- Coverage 68.43% 60.23% -8.20%
==========================================
Files 48 48
Lines 3038 3038
==========================================
- Hits 2079 1830 -249
- Misses 720 967 +247
- Partials 239 241 +2
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `7.14% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `30.24% <0.00%> (-34.68%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: |
| [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `50.00% <0.00%> (-20.41%)` | :arrow_down: |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `52.94% <0.00%> (-12.95%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=footer). Last update [65f792a...b5d5edc](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-798928256
ping @LiteSun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-791477882
I have no idea how to resolve this conflict 😂 please fix it when you have time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#discussion_r580664004
##########
File path: web/src/components/Plugin/PluginDetail.tsx
##########
@@ -243,6 +268,7 @@ const PluginDetail: React.FC<Props> = ({
</Form>
<Divider orientation="left">Data Editor</Divider>
<PageHeader
+ className="test"
Review comment:
Is the style sheet here added correctly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=h1) Report
> Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=desc) (ae4bb28) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2de2c72cfa8899e98045c3059d281b90cf544404?el=desc) (2de2c72) will **decrease** coverage by `30.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1490 +/- ##
===========================================
- Coverage 70.11% 39.47% -30.64%
===========================================
Files 130 49 -81
Lines 5340 3164 -2176
Branches 549 0 -549
===========================================
- Hits 3744 1249 -2495
- Misses 1348 1652 +304
- Partials 248 263 +15
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `39.47% <ø> (ø)` | |
| backend-unit-test | `?` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
| [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
| [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
| [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: |
| [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `33.47% <0.00%> (-44.77%)` | :arrow_down: |
| ... and [102 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=footer). Last update [2de2c72...ae4bb28](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#discussion_r582563832
##########
File path: web/src/helpers.tsx
##########
@@ -130,3 +132,20 @@ export const timestampToLocaleString = (timestamp: number) => {
return moment.unix(timestamp).format('YYYY-MM-DD HH:mm:ss');
};
+
+/**
+ * Transform json string to yaml string
+ * @param jsonStr
+ */
+export const json2yaml = (jsonStr: string): string => {
+ return yaml.dump(JSON.parse(jsonStr))
Review comment:
if jsonStr's value is `''`, an error will occur
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#discussion_r586634700
##########
File path: web/src/helpers.tsx
##########
@@ -130,3 +132,20 @@ export const timestampToLocaleString = (timestamp: number) => {
return moment.unix(timestamp).format('YYYY-MM-DD HH:mm:ss');
};
+
+/**
+ * Transform json string to yaml string
+ * @param jsonStr
+ */
+export const json2yaml = (jsonStr: string): string => {
+ return yaml.dump(JSON.parse(jsonStr))
Review comment:
thanks a lot, already fixed.
use `try...catch` to handle the exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=h1) Report
> Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=desc) (b5d5edc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `16.79%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1490 +/- ##
===========================================
- Coverage 68.43% 51.63% -16.80%
===========================================
Files 48 39 -9
Lines 3038 2597 -441
===========================================
- Hits 2079 1341 -738
- Misses 720 1082 +362
+ Partials 239 174 -65
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
| [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=footer). Last update [65f792a...b5d5edc](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1490: feat: support yaml to config plugin in plugin config page
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #1490:
URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-790270950
Front-end e2e test required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org