[GitHub] [incubator-doris] Gabriel39 commented on a change in pull request #7131: Refactor olap scannode

[GitBox <gi...@apache.org>]

Gabriel39 commented on a change in pull request #7131:
URL: https://github.com/apache/incubator-doris/pull/7131#discussion_r754122278



##########
File path: be/src/exec/olap_scan_node.h
##########
@@ -81,8 +80,8 @@ class OlapScanNode : public ScanNode {
     };
 
     typedef std::priority_queue<HeapType, std::vector<HeapType>, MergeComparison> Heap;
-
-    void display_heap(Heap& heap) {
+    

Review comment:
       my IDE has the same behavior as you for a blank line. I wonder should we keep non-space and non-tab style before a blank line? @morningman 

##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -58,8 +58,7 @@ OlapScanNode::OlapScanNode(ObjectPool* pool, const TPlanNode& tnode, const Descr
           _buffered_bytes(0),
           _eval_conjuncts_fn(nullptr),
           _runtime_filter_descs(tnode.runtime_filters) {}
-
-OlapScanNode::~OlapScanNode() {}
+          

Review comment:
       keep single blank line

##########
File path: be/src/runtime/fragment_mgr.h
##########
@@ -58,7 +58,7 @@ class FragmentMgr : public RestMonitorIface {
     using FinishCallback = std::function<void(PlanFragmentExecutor*)>;
 
     FragmentMgr(ExecEnv* exec_env);
-    virtual ~FragmentMgr();
+    virtual ~FragmentMgr();//why virtual dtor?

Review comment:
       what does this comment mean?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org