You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Dmytro Shteflyuk (Created) (JIRA)" <ji...@apache.org> on 2011/11/15 17:04:51 UTC

[jira] [Created] (HADOOP-7824) Native IO uses wrong constants on OS X

Native IO uses wrong constants on OS X
--------------------------------------

                 Key: HADOOP-7824
                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
             Project: Hadoop Common
          Issue Type: Bug
          Components: native
    Affects Versions: 0.20.205.0, 0.20.204.0
         Environment: Mac OS X
            Reporter: Dmytro Shteflyuk


Constants like O_CREAT, O_EXCL, etc. have different values on OS X.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants almost everywhere

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-7824:
--------------------------------

    Attachment: hadoop-7824.txt

How does something like this look?

Do we need to do the translation for the stat constants, too? Or are those standardized in POSIX?
                
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0, 2.0.0-alpha, 3.0.0
>         Environment: Mac OS X, Linux, Solaris, Windows, ... 
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch, HADOOP-7824.patch, hadoop-7824.txt
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating systems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants on OS X

Posted by "Dmytro Shteflyuk (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmytro Shteflyuk updated HADOOP-7824:
-------------------------------------

    Fix Version/s: 0.20.205.0
                   0.23.0
           Status: Patch Available  (was: Open)

This patch intended to demonstrate how what constants on OS X should look like. It breaks hadoop for systems other then OS X, so it is not intended to be used as is for the Hadoop project.
                
> Native IO uses wrong constants on OS X
> --------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.205.0, 0.20.204.0
>         Environment: Mac OS X
>            Reporter: Dmytro Shteflyuk
>              Labels: hadoop
>             Fix For: 0.23.0, 0.20.205.0
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7824) Native IO uses wrong constants almost everywhere

Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462273#comment-13462273 ] 

Colin Patrick McCabe commented on HADOOP-7824:
----------------------------------------------

I think we should just do the translation in the JNI code.

In general, people expect the jar files to be portable, meaning you can copy them from one PC to another without suffering disaster.  This will not be true if we start injecting native constants into the Java code.  In contrast, {{libhadoop.so}} is designed to contain the operating-system and architecture-specific parts of the code.

Also, do we really want to depend on Perl for our build process?  I realize there's already a {{changes2html.pl}} script, but in general Perl seems like another build dependency we'd be better off without.  Installing Perl on some platforms will definitely be a hassle-- like Windows.  We also don't document our Perl dependency anywhere right now.

bq. I suspect that [translating the constants] is going to be a lot slower.

I seriously doubt that the performance difference between translating the constants and passing them straight through will even be measurable.  If you like, I can do some before and after benchmarks with constant translation and without.  Keep in mind, this is a couple of if statements every time we open a file.  Considering the other performance issues we have to tackle, this is less than noise-- on par with changing constants because you believe comparisons with 0 are faster, etc.
                
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0, 2.0.0-alpha, 3.0.0
>         Environment: Mac OS X, Linux, Solaris, Windows, ... 
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch, HADOOP-7824.patch, hadoop-7824.txt
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating systems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants on OS X

Posted by "Dmytro Shteflyuk (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmytro Shteflyuk updated HADOOP-7824:
-------------------------------------

    Attachment: HADOOP-7824.patch

This patch intended to demonstrate how what constants on OS X should look like. It breaks hadoop for systems other then OS X, so it is not intended to be used as is for the Hadoop project.
                
> Native IO uses wrong constants on OS X
> --------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0
>         Environment: Mac OS X
>            Reporter: Dmytro Shteflyuk
>              Labels: hadoop
>             Fix For: 0.20.205.0, 0.23.0
>
>         Attachments: HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7824) Native IO uses wrong constants almost everywhere

Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402784#comment-13402784 ] 

Allen Wittenauer commented on HADOOP-7824:
------------------------------------------

(well, that and the fact that Java actively works against you if you want to use OS resources)
                
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0, 2.0.0-alpha, 3.0.0
>         Environment: Mac OS X, Linux, Solaris, Windows, ... 
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch, HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating systems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7824) Native IO uses wrong constants almost everywhere

Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402766#comment-13402766 ] 

Allen Wittenauer commented on HADOOP-7824:
------------------------------------------

I suspect that's going to be a lot slower.  The C compiler should be able to optimize the heck out of pre-generated code rather than doing it on the fly. Given that the whole reason why this code exists is speed....
                
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0, 2.0.0-alpha, 3.0.0
>         Environment: Mac OS X, Linux, Solaris, Windows, ... 
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch, HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating systems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants almost everywhere

Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Foley updated HADOOP-7824:
-------------------------------

    Target Version/s: 2.0.0-alpha, 1.2.0, 3.0.0  (was: 1.1.0, 2.0.0-alpha, 3.0.0)
    
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0, 2.0.0-alpha, 3.0.0
>         Environment: Mac OS X, Linux, Solaris, Windows, ... 
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch, HADOOP-7824.patch, hadoop-7824.txt
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating systems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants on OS X

Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-7824:
--------------------------------

     Target Version/s: 0.20.206.0, 0.23.1  (was: 0.23.0)
    Affects Version/s: 0.23.0
        Fix Version/s:     (was: 0.20.205.0)
                           (was: 0.23.0)
    
> Native IO uses wrong constants on OS X
> --------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 0.23.0
>         Environment: Mac OS X
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants almost everywhere

Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated HADOOP-7824:
-------------------------------------

          Environment: Mac OS X, Linux, Solaris, Windows, ...   (was: Mac OS X, Linux, Solaris, ... )
     Target Version/s: 2.0.0-alpha, 1.1.0, 3.0.0  (was: 1.1.0, 2.0.0-alpha, 3.0.0)
    Affects Version/s: 3.0.0
                       2.0.0-alpha
    
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0, 2.0.0-alpha, 3.0.0
>         Environment: Mac OS X, Linux, Solaris, Windows, ... 
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch, HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating systems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7824) Native IO uses wrong constants on OS X

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150578#comment-13150578 ] 

Hadoop QA commented on HADOOP-7824:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503759/HADOOP-7824.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/376//console

This message is automatically generated.
                
> Native IO uses wrong constants on OS X
> --------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0
>         Environment: Mac OS X
>            Reporter: Dmytro Shteflyuk
>              Labels: hadoop
>             Fix For: 0.20.205.0, 0.23.0
>
>         Attachments: HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants on OS X

Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-7824:
--------------------------------

    Status: Open  (was: Patch Available)

cancelling patch - I'm not actively working on this but when I get some free time I will try to circle back. If anyone else wants to steal from me, feel free.
                
> Native IO uses wrong constants on OS X
> --------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.23.0, 0.20.205.0, 0.20.204.0
>         Environment: Mac OS X
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants almost everywhere

Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated HADOOP-7824:
-------------------------------------

     Target Version/s: 2.0.0-alpha, 1.1.0, 3.0.0  (was: 2.0.0-alpha, 3.0.0)
    Affects Version/s: 1.0.3
              Summary: Native IO uses wrong constants almost everywhere  (was: Native IO uses wrong constants on OS X)

Changing this to reflect reality.  NativeIO.java's definitions mismatch RHEL 6 as well, which means that even on Linux this is untrustworthy.
                
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0
>         Environment: Mac OS X
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants almost everywhere

Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated HADOOP-7824:
-------------------------------------

    Attachment: HADOOP-7824.patch

This patch generates a bit field translator based upon what Hadoop thinks is true in NativeIO.java vs. what fcntl.h and friends know is real.

This isn't fully cooked into the build process yet, however.
                
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0
>         Environment: Mac OS X
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch, HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HADOOP-7824) Native IO uses wrong constants on OS X

Posted by "Todd Lipcon (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon reassigned HADOOP-7824:
-----------------------------------

    Assignee: Todd Lipcon
    
> Native IO uses wrong constants on OS X
> --------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0
>         Environment: Mac OS X
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>             Fix For: 0.20.205.0, 0.23.0
>
>         Attachments: HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants almost everywhere

Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated HADOOP-7824:
-------------------------------------

         Description: Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating systems.  (was: Constants like O_CREAT, O_EXCL, etc. have different values on OS X.)
         Environment: Mac OS X, Linux, Solaris, ...   (was: Mac OS X)
    Target Version/s: 2.0.0-alpha, 1.1.0, 3.0.0  (was: 1.1.0, 2.0.0-alpha, 3.0.0)
    
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0
>         Environment: Mac OS X, Linux, Solaris, ... 
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch, HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating systems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7824) Native IO uses wrong constants on OS X

Posted by "Robert Joseph Evans (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-7824:
----------------------------------------

    Target Version/s: 2.0.0, 3.0.0  (was: 0.23.2)
    
> Native IO uses wrong constants on OS X
> --------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 0.23.0
>         Environment: Mac OS X
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7824) Native IO uses wrong constants almost everywhere

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402763#comment-13402763 ] 

Todd Lipcon commented on HADOOP-7824:
-------------------------------------

Instead of generating code at compile time like this, can we do better by creating enums on the Java side, and then translating from the Java enum to the C constants in the JNI layer? See how Errno.java translates to its C counterpart.
                
> Native IO uses wrong constants almost everywhere
> ------------------------------------------------
>
>                 Key: HADOOP-7824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 0.20.204.0, 0.20.205.0, 1.0.3, 0.23.0
>         Environment: Mac OS X, Linux, Solaris, ... 
>            Reporter: Dmytro Shteflyuk
>            Assignee: Todd Lipcon
>              Labels: hadoop
>         Attachments: HADOOP-7824.patch, HADOOP-7824.patch
>
>
> Constants like O_CREAT, O_EXCL, etc. have different values on OS X and many other operating systems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira